Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destroy method is broken #3

Closed
etpinard opened this issue Mar 28, 2018 · 2 comments
Closed

destroy method is broken #3

etpinard opened this issue Mar 28, 2018 · 2 comments

Comments

@etpinard
Copy link
Member

const regl = require('regl')({ extensions: 'oes_element_index_uint' })
const createMatrix = require('./')


// create splom instance
let splom = createMatrix(regl)

splom.update({
  data: [
    [1, 2, 3],
    [4, 6, 8]
  ],
  ranges: [
    [0, 10],
    [0, 10]
  ]
})

splom.draw()

setTimeout(() => {
  splom.destroy()
}, 2000)

spits out

image

cc @dfcreative

etpinard added a commit to plotly/plotly.js that referenced this issue Mar 28, 2018
... the destroy method for regl-scattermatrix instance is broken,
    see gl-vis/regl-splom#3
@dy
Copy link
Member

dy commented Mar 29, 2018

Fixed 7ac2624

@dy dy closed this as completed Mar 29, 2018
@etpinard
Copy link
Member Author

In plotly.js with plotly/plotly.js@32118b0

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants