fix(privateMocks): allow replacing $prop with strings with special …

…RegExp semantics `baseThey` used to construct the testcase description by replacing `$prop` using a RegExp. If the replacement string contained `$&` (which has a special meaning with RegExps), the resulting string was not as expected.x
gkalpak · Dec 15, 2015 · 031303d · 031303d · Narretz · Dec 15, 2015
1 parent 1b25f80
commit 031303d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/test/helpers/privateMocks.js b/test/helpers/privateMocks.js
@@ -11,7 +11,7 @@ function baseThey(msg, vals, spec, itFn) {
   var valsIsArray = angular.isArray(vals);
 
   angular.forEach(vals, function(val, key) {
-    var m = msg.replace(/\$prop/g, angular.toJson(valsIsArray ? val : key));
+    var m = msg.split('$prop').join(angular.toJson(valsIsArray ? val : key));
     itFn(m, function() {
       /* jshint -W040 : ignore possible strict violation due to use of this */
       spec.call(this, val);