Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Sass >=1.79.0 (fractional rgb(), hsla() with no slash) #362

Open
Ambient-Impact opened this issue Oct 19, 2024 · 2 comments

Comments

@Ambient-Impact
Copy link

First off, thanks for this awesome library. It's a huge time saver and I wouldn't be opening this issue if didn't already work flawlessly 99% of the time.

It looks like Sass >=1.79.0 made some changes in how it outputs some colours, likely to keep up to date with the CSS Color 4 specification. In short, these are supposed to be valid (according to Sass) but chroma.js throws an error, saying that they're unknown formats:

hsla(0deg 0% 10% 0)

This seems to be fixed by adding the / separator for the alpha value:

hsla(0deg 0% 10% / 0)

This also fails:

rgb(6.375 6.375 6.375)

Looks like fractional/float values are supported by both the specification, and also in my quick/informal testing in Firefox and Chromium as well.

@Ambient-Impact
Copy link
Author

Ambient-Impact commented Oct 19, 2024

Closing as restricting the Sass version fixes this for now. Will be reopened at a later date if needed.

@Ambient-Impact
Copy link
Author

Whoops wrong tab. Ignore my last comment.

Ambient-Impact added a commit to neurocracy/omnipedia that referenced this issue Oct 19, 2024
…fc9):

Restrict sass ^1.43.4 <1.79.0 to fix busted eased gradients:

gka/chroma.js#362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant