Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting ob-julia for org 9.2.5 and Julia 1.1.1 #16

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

phrb
Copy link

@phrb phrb commented Aug 20, 2019

I've tried to make ob-julia.el work with org 9.2.5 and Julia 1.1.1, by updating functions with code from ob-R.el.

These changes restore support for source blocks with :results output and :results value, with and without :session.

- Stop relying on ess to set current buffer
- Remove some extra newlines
- It now works with and without :session, for :results value and :results output
@phrb phrb changed the title :results output and :session: ob-julia for org 9.2.5 and Julia 1.1.1 Porting ob-julia for org 9.2.5 and Julia 1.1.1 Aug 20, 2019
@nico202
Copy link
Contributor

nico202 commented Aug 20, 2019

Have you taken a look at my work on #15? I did some work to support the :file output too. Also in that PR the owner says he's not going to maintain ob-julia anymore

@phrb
Copy link
Author

phrb commented Aug 20, 2019

I hadn't seen it, thanks for posting.

Would you be interested in forking this project?

@nico202
Copy link
Contributor

nico202 commented Aug 20, 2019

Yes, but I'm not sure at which stage my progresses were. I just pushed my latest commit (to master), if you can take a look and tell me what does not work / PR something there :)

Thanks

@gjkerns
Copy link
Owner

gjkerns commented Aug 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants