Fix: Add 'speak: none' to FontAwesome icons for accessibility.

CHANGES.txt

@@ -6,6 +6,7 @@ New in 3.0.1.1
 - FIX: Style guide settings tooltips and popups.
 - FIX: MDL-52936 - Fix link hover bug on iOS.
 - FIX: Apply 'aria-hidden="true"' to FontAwesome icons as much as possible.  Still a few 'content' CSS attributes to consider.
+- FIX: Add 'speak: none' to FontAwesome icons for accessibility.
 - NEW: Issue #632: View StyleGuide without logging on.
 
 New in 3.0.1

classes/output/core_renderer.php

@@ -1312,10 +1312,10 @@ public function render_pix_icon(pix_icon $icon) {
         if (array_key_exists($icon->pix, $icons)) {
             $pix = $icons[$icon->pix];
             if (empty($icon->attributes['alt'])) {
-                return '<span class="fa fa-'.$pix.' icon" aria-hidden="true">'.parent::render_pix_icon($icon).'</span>';
+                return '<span class="fa fa-'.$pix.' icon" aria-hidden="true"></span>';
             } else {
                 $alt = $icon->attributes['alt'];
-                return '<span class="fa fa-'.$pix.' icon" title="'.$alt.'" aria-hidden="true">'.parent::render_pix_icon($icon).'</span>';
+                return '<span class="fa fa-'.$pix.' icon" title="'.$alt.'" aria-hidden="true"></span>';
             }
         } else {
             return parent::render_pix_icon($icon);

less/essential.less

@@ -78,6 +78,7 @@
 // Start with core.
 @import "essential/core";
 // Import the essential styles.
+@import "essential/accessibility";
 @import "essential/admin";
 @import "essential/alert";
 @import "essential/autocomplete";

less/essential/accessibility.less

@@ -0,0 +1,5 @@
+// Do not vocalise icons.
+// Ref: http://www.w3schools.com/cssref/css_ref_aural.asp.
+.@{fa-css-prefix}, :before {
+    speak: none;
+}

less/moodle/pix/course.less

@@ -7,7 +7,7 @@
 
 .coursebox > .info > .coursename a {
     //background-image:url([[pix:moodle|i/course]]);
-    background-image: transparent;
+    background-image: none;
 }
 .dir-rtl .coursebox > .info > .categoryname a {
     //background-position: center right;