Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out client singleton or module variable #6

Closed
gizmo385 opened this issue Sep 9, 2024 · 0 comments
Closed

Pull out client singleton or module variable #6

gizmo385 opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@gizmo385
Copy link
Owner

gizmo385 commented Sep 9, 2024

The GithubClient is currently manually threaded to every widget and helper function that needs it. Given that we don't actually need there to be more than a single client active at once, we should pull this out into a singleton or module variable.

@gizmo385 gizmo385 added the enhancement New feature or request label Sep 9, 2024
@gizmo385 gizmo385 changed the title Pull out client singleton or context variable Pull out client singleton or module variable Sep 9, 2024
gizmo385 added a commit that referenced this issue Sep 9, 2024
This should make adding new screens and views easier since we won't have
to thread the existing GithubClient through the entire UI

This addresses #6
@gizmo385 gizmo385 closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant