-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edit allowance page within generosity challenge #856
Fix edit allowance page within generosity challenge #856
Conversation
WalkthroughThe recent changes refine the handling of allowance within the "GenerosityChallenge" and "EditAllowancePage". Specifically, a constructor adjustment in Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- lib/features/children/generosity_challenge/assignments/set_up_allowance/generosity_allowance_flow_page.dart (2 hunks)
- lib/features/children/overview/pages/edit_allowance_page.dart (5 hunks)
Additional comments not posted (5)
lib/features/children/generosity_challenge/assignments/set_up_allowance/generosity_allowance_flow_page.dart (2)
13-15
: Constructor changes are correct.The constructor has been updated with new key-value pairs. These changes are correct.
Line range hint
27-44
: Verify the removal of theinitialAllowance
parameter.The
initialAllowance
parameter has been removed from theEditAllowancePage
. Ensure that this change is consistent with the rest of the codebase and does not cause any issues.lib/features/children/overview/pages/edit_allowance_page.dart (3)
4-4
: Import changes are correct.The
FamilyAppTheme
import has been added correctly.
46-46
: Variable definition is correct.The
theme
variable has been defined usingFamilyAppTheme
correctly.
72-89
: Text style updates are correct.The text styles have been updated to use properties from
FamilyAppTheme
instead ofTheme.of(context)
. These changes are correct and consistent.Also applies to: 104-108, 143-147
Description
Summary by CodeRabbit
New Features
Edit Allowance Page
to use the consistent family app theme.Bug Fixes
initialAllowance
parameter to fix inconsistent allowance setup.Refactor