Bug: Fix family counter page not always showing user profile icon

[TammiLion]

Summary by CodeRabbit

• New Features
  • Enhanced MemberCounter component to manage its own state, allowing for better data refresh capabilities.
• Bug Fixes
  • Improved initialization process to ensure family member icons are correctly refreshed and displayed.

[coderabbitai]

Walkthrough

The changes involve modifying the MemberCounter class in the member_counter.dart file from a StatelessWidget to a StatefulWidget. This transition introduces state management through a new _MemberCounterState class. The createState method is added to instantiate this state class, and the initState method is implemented to refresh profiles upon initialization. Additionally, the BlocBuilder clears the familyMembersIcons list before populating it, ensuring accurate state management.

Changes

File Path	Change Summary
lib/features/children/add_member/widgets/member_counter.dart	Changed MemberCounter from StatelessWidget to StatefulWidget, added createState and _MemberCounterState, and implemented initState for profile refreshing.

Poem

In the meadow where bunnies play,
A counter's changed in a wondrous way.
From stateless to stateful, it now can sing,
Refreshing profiles, oh what joy it brings!
With icons anew, let the fun abound,
Hopping along, where happiness is found! 🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 43af828 and c7720e5.

📒 Files selected for processing (1)

• lib/features/children/add_member/widgets/member_counter.dart (4 hunks)

🧰 Additional context used

🔇 Additional comments (4)

lib/features/children/add_member/widgets/member_counter.dart (4)

Line range hint 8-24: Conversion to StatefulWidget is properly implemented

The MemberCounter widget has been successfully converted from a StatelessWidget to a StatefulWidget. The createState method correctly returns an instance of _MemberCounterState, enabling state management within the widget.

---

35-36: Property access updated with 'widget' prefix

All property references within the State class have been correctly updated to use the widget prefix (e.g., widget.displayFamily and widget.otherMembersIcons), which is necessary for accessing properties of the StatefulWidget.

---

84-87: Correct order of initialization in 'initState'

The initState method correctly calls super.initState(); as the first line, ensuring that the state is properly initialized before any other operations. The subsequent call to context.read<ProfilesCubit>().refresh(); will now function as expected.

---

29-30: Ensure 'placeholdercount' is non-negative to prevent errors

In the calculation of placeholdercount:

final placeholdercount = widget.totalCount - avatarsCount;

Please verify that widget.totalCount is always greater than or equal to avatarsCount to prevent placeholdercount from becoming negative. A negative value could cause issues with List.generate, leading to runtime errors.

To confirm that placeholdercount remains non-negative, you can check all instances where MemberCounter is used:

[coderabbitai]

⚠️ Potential issue

Redundant clearing of 'familyMembersIcons'

The call to familyMembersIcons.clear(); is redundant because familyMembersIcons is a newly initialized local list within the _buildFamilyIcons method.

You can remove the unnecessary clear() call to simplify the code:

-        familyMembersIcons.clear();

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

familyMembersIcons.clear();