Bugfix: Add permission check if android bluetooth is on ( kids-1278 )

[Daniela510]

Core issue is that if the android device has bluetooth turned on but permissions declined the BluetoothAdapterState returns .on instead of the expected .unauthorized like on iOS. So it would attempt to startBluetoothScan -> FlutterBluePlus.startScan but get stuck in a loop failing and restarting the attempt.
Solution: Check for permissions if it is an Android device before attempting to start scanning.

Summary by CodeRabbit

• New Features

  • Enhanced Bluetooth permission handling for Android devices.
  • Introduced a dialog to inform users when Bluetooth permissions are denied.

• Bug Fixes

  • Improved logic for responding to unauthorized Bluetooth adapter states.

[coderabbitai]

Walkthrough

The changes in this pull request primarily focus on enhancing the BTScanPage class within the bt_scan_page.dart file by implementing Bluetooth permission handling for Android devices. This includes the addition of a new method to display a dialog when Bluetooth permissions are denied and an update to the initialization method to check for these permissions before proceeding with Bluetooth scanning. The overall structure of the scanning logic remains unchanged, but the user interaction for permission handling is now more robust.

Changes

File	Change Summary
lib/features/give/pages/bt_scan_page.dart	- Added showBluetoothDeniedDialog method for handling permission denial. - Updated initBluetooth to check Bluetooth permissions before scanning. - Replaced previous dialog logic with the new method for unauthorized Bluetooth adapter states.

Possibly related PRs

• Don't start bluetooth scan, should go automatically when turned on (KIDS-1353) #1048: The changes in this PR also modify the _BTScanPageState class in the bt_scan_page.dart file, focusing on Bluetooth scanning logic and state management, which is directly related to the modifications made in the main PR regarding Bluetooth permission handling.

Suggested labels

bug

Poem

In the meadow, we hop and play,
With Bluetooth now safe, hip-hip-hooray!
Permissions checked, no need to fear,
A dialog pops up, loud and clear!
So scan away, dear friends, with glee,
For hopping with Bluetooth is the way to be! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)

lib/features/give/pages/bt_scan_page.dart (1)

Line range hint 27-28: Swap variable names for clarity.

The variables adapterStateStream and scanResultsStream appear to be misnamed. adapterStateStream is subscribing to scanResults, and scanResultsStream is subscribing to adapterState. Swapping the variable names would improve code readability and reduce confusion.

Apply this diff to correct the variable names:

-StreamSubscription<List<ScanResult>>? adapterStateStream;
-StreamSubscription<BluetoothAdapterState>? scanResultsStream;
+StreamSubscription<List<ScanResult>>? scanResultsStream;
+StreamSubscription<BluetoothAdapterState>? adapterStateStream;

...

-// Set listen method for scan results
-adapterStateStream = FlutterBluePlus.scanResults.listen(
+// Set listen method for scan results
+scanResultsStream = FlutterBluePlus.scanResults.listen(

...

-// Listen to scan mode changes
-scanResultsStream = FlutterBluePlus.adapterState
+// Listen to adapter state changes
+adapterStateStream = FlutterBluePlus.adapterState

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a949f07 and 9ad97cd.

📒 Files selected for processing (1)

• lib/features/give/pages/bt_scan_page.dart (5 hunks)

🧰 Additional context used