show declined kids transactions (KIDS-1235)

[MaikelStuivenberg]

Summary by CodeRabbit

• New Features

  • Enhanced filtering for donation history, allowing for more specific retrieval based on donation status and type.

• Bug Fixes

  • Improved accuracy in fetching history records by refining conditional logic for filtering out certain donation records.

[coderabbitai]

Walkthrough

The changes in this pull request modify the fetchHistory method of the HistoryRepositoryImpl class. The update refines the filtering logic for donation records, specifically regarding the exclusion of donations based on their status and type. The new logic introduces an additional condition that allows for more precise filtering of records, ensuring that only certain donations are excluded from the results.

Changes

File Path	Change Summary
lib/features/family/features/history/history_repository/history_repository.dart	Modified the fetchHistory method to refine filtering logic for donation records based on status and type.

Assessment against linked issues

Objective	Addressed	Explanation
Show declined donations not declined top ups (KIDS-1235)	✅

Suggested labels

bug

Poem

🐇 In the garden where donations bloom,
A tweak was made to clear the gloom.
Declined ones now find their way,
To children's hearts, come what may!
Hopping with joy, we celebrate,
A change so bright, it feels like fate! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

lib/features/family/features/history/history_repository/history_repository.dart (1)

38-43: Approved changes with suggestions for improvement

The changes successfully address the PR objective of showing declined donations in the child's "My Givts" section. The new filtering logic correctly includes rejected or cancelled donations while excluding other types of transactions with these statuses.

However, I have a few suggestions to improve the code:

1. Refactor for readability:

-      if ((donationMap['status'] == 'Rejected' ||
-              donationMap['status'] == 'Cancelled') &&
-          donationMap['donationType'] != HistoryTypes.donation.value) {
+      final isRejectedOrCancelled = donationMap['status'] == 'Rejected' || donationMap['status'] == 'Cancelled';
+      final isNotDonation = donationMap['donationType'] != HistoryTypes.donation.value;
+      if (isRejectedOrCancelled && isNotDonation) {
         continue;
       }

2. Add null checks to prevent potential null pointer exceptions:

+      final status = donationMap['status'] as String?;
+      final donationType = donationMap['donationType'] as String?;
+      final isRejectedOrCancelled = status == 'Rejected' || status == 'Cancelled';
+      final isNotDonation = donationType != null && donationType != HistoryTypes.donation.value;
       if (isRejectedOrCancelled && isNotDonation) {
         continue;
       }

3. Add a comment explaining the logic:

+      // Include rejected or cancelled donations, but exclude other transaction types with these statuses
       final status = donationMap['status'] as String?;
       final donationType = donationMap['donationType'] as String?;
       final isRejectedOrCancelled = status == 'Rejected' || status == 'Cancelled';
       final isNotDonation = donationType != null && donationType != HistoryTypes.donation.value;
       if (isRejectedOrCancelled && isNotDonation) {
         continue;
       }

These changes will improve code readability, robustness, and maintainability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 32019ad and 289603f.

📒 Files selected for processing (1)

• lib/features/family/features/history/history_repository/history_repository.dart (1 hunks)

🧰 Additional context used