Simplify the setup script, capture only what is absolutely needed #576 #591
Conversation
packages/setup/src/index.ts
Outdated
| ); | ||
|
|
||
| const apiEnv = { | ||
| MONGO_INITDB_ROOT_USERNAME: randomString(12), |
There was a problem hiding this comment.
Don't generate random usernames for root username and username. Use the ones specified in .env.template
packages/setup/src/index.ts
Outdated
|
|
||
| const apiEnv = { | ||
| MONGO_INITDB_ROOT_USERNAME: randomString(12), | ||
| MONGO_INITDB_ROOT_PASSWORD: randomString(12), |
There was a problem hiding this comment.
Passwords should not be regenerated on each run
packages/setup/src/index.ts
Outdated
| }); | ||
| dotenv.config({ path: '/usr/praise/packages/frontend/.env', override: true }); | ||
| dotenv.config({ path: '/usr/praise/.env.template', override: false }); | ||
| dotenv.config({ path: '/usr/praise/.env', override: false }); |
There was a problem hiding this comment.
Override should be true, right? The template should override any pre-existing env settings. And the "real" .env should override the template.
| @@ -133,18 +125,30 @@ const questions = [ | |||
| }, | |||
| ]; | |||
|
|
|||
There was a problem hiding this comment.
I added this because i wanted to use process env variable if exists. If not than we can build url depending on node env
And also i moved this to separate method because of SonarCloud was reporting code smell if we have nested conditionals
Co-authored-by: Kristofer <[email protected]>
…ack/praise into simplify_setup_script
|
Kudos, SonarCloud Quality Gate passed!
|
Resolves #576