-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bot message for the first time praisers #516
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c2c452a
Added bot message for the first time praisers
nebs-dev 07463a8
Updated message
kristoferlund 5a4992e
Added to default firstTimePraiserInfo msg
kristoferlund cf09017
Changing firstTimePraiserInfo message
kristoferlund c52fc5c
use less expensive call to count praise items for the praise giver
nebs-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
packages/api/src/database/migrations/17_settings_first_time_praiser.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import { SettingGroup } from '@/settings/types'; | ||
import { SettingsModel } from '../../settings/entities'; | ||
|
||
const settings = [ | ||
{ | ||
key: 'FIRST_TIME_PRAISER', | ||
value: | ||
'**😃 We noticed this is the first time you praise!**\n Find here some info about what makes good Praise: https://givepraise.xyz', | ||
type: 'Textarea', | ||
label: 'First Time Praiser Message', | ||
description: 'Make a great new praise!', | ||
group: SettingGroup.DISCORD, | ||
}, | ||
]; | ||
|
||
const up = async (): Promise<void> => { | ||
const settingUpdates = settings.map((s) => ({ | ||
updateOne: { | ||
filter: { key: s.key }, | ||
|
||
// Insert setting if not found, otherwise continue | ||
update: { $setOnInsert: { ...s } }, | ||
upsert: true, | ||
}, | ||
})); | ||
|
||
await SettingsModel.bulkWrite(settingUpdates); | ||
}; | ||
|
||
const down = async (): Promise<void> => { | ||
const allKeys = settings.map((s) => s.key); | ||
await SettingsModel.deleteMany({ key: { $in: allKeys } }); | ||
}; | ||
|
||
export { up, down }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q) Wouldn't this become an expensive call?
Could we send this message to users when they activate their praise account instead of sending it on first praise?
__
Summary: ❓ I have a question | Tags: Inefficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any huge performance concerns here since praising is relatively infequent. But yes, this does seem like an overly expensive call. To begin with I'd suggest we try doing
PraiseModel.countDocuments(
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should make this more feasible 👍