Frontend styling refactor / UI polish #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattyg
reviewed
Jun 18, 2022
mattyg
requested changes
Jun 18, 2022
packages/frontend/src/pages/QuantifyPeriodReceiver/components/QuantifyPraiseRow.tsx
Show resolved
Hide resolved
One common way to deal with this is to use an "outline" button style with the same colour. That is then used for with "less important" buttons, in relation to some "more important" button. In the case of the quantify screen, both buttons are of equal importance which makes it more difficult to motivate why they should have different colours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started polishing up the UI. There is still lots to do, mostly in terms of responsiveness and dark mode. But I think this is bug free enough to merge for now.