Feat/264/limiting channel praise access #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vyvy-vi
force-pushed
the
feat/264/limiting-channel-praise-access
branch
from
ffdae2c to
bb276ba
Compare
kristoferlund
previously requested changes
Jun 8, 2022
There was a problem hiding this comment.
Great, seems to be working as intended!
I merged #440 with main and then merged this branch and solved some small conflicts.
#440 moves all Praise Giver checking into the function assertPraiseGiver- Perhaps we should consider renaming praiseAllowedInChannel assertPraiseAllowedInChannel?
#440 also removes getSetting in favour of using the settingValue in api/dist/shared/settings.
Needs fixing:
12_praise_allowed_channels_settings.tsshould start with 14 to avoid conflict.
Vyvy-vi
force-pushed
the
feat/264/limiting-channel-praise-access
branch
from
f9cd5e2 to
6bb0349
Compare
|
@Vyvy-vi I don't remember, are there more changes needed for this PR? |
|
This PR's good to go! |
kristoferlund
previously requested changes
Jun 20, 2022
packages/api/src/database/migrations/15_praise_allowed_channels_settings.ts
Outdated
Show resolved
Hide resolved
|
dependent on #521 being merged before |
Vyvy-vi
force-pushed
the
feat/264/limiting-channel-praise-access
branch
from
9200385 to
28e2f77
Compare
|
@Vyvy-vi, this PR is confusing me a bit. It says it is merged but I find no trace of the functionality. What happened? |
kristoferlund
approved these changes
Aug 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
This Pr adds the following settings to the bot -
Praise is enabled by default in all channels of the server