-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support multiple wallets #424
Conversation
…ut' and 'SignMessageButton', utilizing rainbowkit and wagmi instead of useWeb3React
…ssageLayout, instead of using ConnectButton -- when account is connected
…ilt-in support in rainbowkit
… wallet not connected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rainbow looks nice, definitely supports more wallets than web3-react!
Here are some initial comments:
I've only tried the Argent Wallet integration so far. Connecting wallet worked fine, logging into website didn't work - no error specified. Argent didn't present me with the message to sign, only a generic "Praise is requesting your signature". I think we need to verify all supported wallets work before enabling them.
While in the connected state but before signing login message the user is sort of stuck. To switch back to Metamask I had to clear LocalStorage. We need to provide a "Disconnect" button. Let's make a popup similar to how Rainbow does it. Accessed by a "down chevron" next to the eth address. This popup we can reuse when user is fully logged in as well.
I am getting a lot of build errors when starting through VSCode:
And finally. Rainbow adds a lot to the frontend package size. Is there any way to shrink that?
… add 'walletconnect'
…s, or disconnect. Replace logout nav to use EthAccountDialog
… longer generate a source map
…rather than by disabling source maps
Verified all wallets working properly except for Argent & SteakWallet -- removed them.
Done
It looks like these are caused to changes in Webpack 5 which requires dependencies to publish their source files. See As a workaround, I ignored these warnings via webpack config.
Hopefully #426 will reduce the overall app size. Otherwise will have to dig into other options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think Argent has some different requirements to setup message signing since it's a "smart contract wallet" -- I didn't dig into the details much more: https://docs.argent.xyz/wallet-connect-and-argent#message-signature |
Resolves #352
Overview
web3-react
@rainbow-me/rainbowkit
To reduce the scope, I did not include WalletConnect in the rainbowkit ux, as it will require additional setup per-instance (registering each app instance with WalletConnect). Though this could be added in the future if desired.