-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/settings grouped #399
Conversation
…. Replace 'periodOverridable' with group SettingGroup.PERIOD_DEFAULT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N I C E !
I'm wondering if this is a good time to remove the
App Name
andApp Description
settings? Or if we want to keep them, should we display them somewhere?
Yeah, I don't see us using them anywhere, please toast them.
I also did not include setting ordering in this PR. Let me know if you think that should be included.
That can definitely wait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
Resolves #131
Resolves #333
I'm wondering if this is a good time to remove the
App Name
andApp Description
settings? Or if we want to keep them, should we display them somewhere?Overview
group
field to SettingModelperiodOverridable
, with group SettingGroup.PERIOD_DEFAULTJust a note that I went with the following display names for the settings group NavItems:
Let me know if you think the names in the mockup are preferable.
I also did not include setting ordering in this PR. Let me know if you think that should be included.