Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/highlight nav #396

Merged
merged 13 commits into from
May 16, 2022
Merged

Fix/highlight nav #396

merged 13 commits into from
May 16, 2022

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented May 15, 2022

Resolves #244

I also included a few minor changes to the route paths and login navigation -- see below:

Overview

  • Copied work from Fix/highlight nav #335
  • Make active routes less prominently highlighted
  • Make period detail route path a sub-path of periods list
  • Make quantify route path a sub-path of periods detail route
  • Always direct user to home page route / on login
  • Remove 1 second delay on successful login

@mattyg mattyg mentioned this pull request May 15, 2022
@mattyg mattyg requested a review from kristoferlund May 15, 2022 17:36
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kristoferlund kristoferlund merged commit 58af438 into main May 16, 2022
@kristoferlund kristoferlund deleted the fix/highlight-nav branch May 16, 2022 10:54
@kristoferlund kristoferlund mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight current page in Navs
3 participants