Create user screen #395
Create user screen #395
Conversation
… from the last admin
| <div className="w-1/3 flex items-center gap-4"> | ||
| <UserAvatar user={data} /> | ||
| <span className=" font-mono text-sm"> | ||
| {shortenEthAddress(data.ethereumAddress!)} |
There was a problem hiding this comment.
The user.ethereumAddress should always be defined (according to the mongoose entity).
Thus I think we can should modify the User & UserDto types to reflect this (make ethereumAddresss no longer optional). Then you won't need this non-null assertion.
There was a problem hiding this comment.
Doesn't this collide with the needs of #361? If the User is created before account activation we don't know the eth address.
packages/frontend/src/pages/Users/components/UsersTablePagination.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/pages/Users/components/UsersTableHeader.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @pkretzschmar! This is great!!
I left a bunch of inline comments with requested changes (and a few things that weren't working).
Let me know if you want to go over any of this together! Or even pair-program some of it if you're interested! 😃
|
Yes, good stuff @pkretzschmar! Just a little bit of polishing needed, then it's done. |
…to ignore eslint rule no-misused-promises
…ed data is missing, return null
…core functionality of which is implemented in a helper util
… -- instead return null if component does not have all needed data
…ed (reflect changes in #365), switch to using shortenEthAddress implementation from api.
…se opacity slightly to reflect mockup
There was a problem hiding this comment.
Awesome! 🔥
I went through and made a bunch of minor changes:
- deleted two components that are no longer needed
- changed label of users page NavItem to "Users"
- remove eslint ignore unused promises (see inline message response)
- remove new dependency 'classnames' -- we've been using a local utility 'classNames' in
utils/index.tsfor the same functionality - hide ethereum address when it is identical to user name
- remove frontend function
getUsername-- instead useuser.nameRealized(reflect refactoring done in Feat/user event log #365 while this PR was open) - remove frontend implementation of shortenEthAddress, use implementation (reflect refactoring done in Feat/user event log #365 while this PR was open)
- prevent list of roles from breaking mid-word
I think there are just 3 issues remaining. I made screencasts to demonstrate them:
- The pagination buttons do not change when the users list is limited to searched text:
Kazam_screencast_00003.mp4
-
The UserTable overlaps itself on small screens, and overflows the content area.
-
The role toggle buttons seem to be able to get into a weird state where they don't reflect the backend user.roles. I'm pretty sure this is related to use of
useRecoilCallbackwithinuseAdminUsers. The frontend state setup is kinda confusing, so please let me know if I can help! We could also pair-program through this sometime if that's helpful!
Kazam_screencast_00001.mp4
|
Also @pkretzschmar I know you've got other projects you're working on -- if you have limited availability to finish up this PR and #356 just let me know and I can pick up where you left off! |
pkretzschmar
force-pushed
the
feat/admin-screen
branch
from
aab864c to
3c5e373
Compare
There was a problem hiding this comment.
Yes! Nice work @pkretzschmar! I tweaked some paddings and made some other smaller fixes. Merging this now.
Resolves #320