Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API allows for duplicate Discord User accounts to be connected to one User #398

Closed
kristoferlund opened this issue May 16, 2022 · 4 comments
Labels
api bug Something isn't working

Comments

@kristoferlund
Copy link
Member

image

This happens when you start with a fresh db with dummy data and then activate your account using the bot. Two Discord user accounts.

@kristoferlund kristoferlund added bug Something isn't working api labels May 16, 2022
@mattyg
Copy link
Collaborator

mattyg commented May 16, 2022

I think it's correct behavior that multiple user accounts on the same platform can be linked to the same user. Why disallow it?

I think there might be some confusion around the seeder? In seed.ts, the function seedPredefinedUsers seeds a User and UserAccount for all "admin" ethereum address statically defined in PREDEFINED_USERS. Because your ethereum address is in PREDEFINED_USERS it seeds a user with your ethereum address and a connected user account. Then when you activate a user account on discord with the same ethereum address, it is also connected to the already existing User.

@kristoferlund
Copy link
Member Author

I think it's correct behavior that multiple user accounts on the same platform can be linked to the same user. Why disallow it?

Perhaps (most likely) you are right. Me and Rudolf discussing this at length but I cannot remember what would be the reason to disallow it.

Closing this issue.

@kristoferlund
Copy link
Member Author

I'm opening this issue again. The real world usecase for this is an edge case. I have never heard about a situation where one individual is involved in one community under more than one discord user. Unless one user is some sort of test account or similar.

Even though it is not technically complex to allow multiple user accounts for one platform it creates complexity elsewhere. I just opened up #402 for instance. If the rule is one user = one discord account and one telegram account then we can easily create a csv export like this:

user.id user.etherumAddress discord.accountId discord.name telegram.accountId  telegram.name
1       0x123               1324243           user#1244    8769876             cool_user
2       0x123               134243            user#9899    8987589             not_so_cool_user

@mattyg Wouldn't it be reasonable to say that currently: one user has one user account per platform?

We can always open up the possibility for more than one account later. But I do believe it is an edge case.

@mattyg
Copy link
Collaborator

mattyg commented May 18, 2022

I'm opening this issue again. The real world usecase for this is an edge case. I have never heard about a situation where one individual is involved in one community under more than one discord user. Unless one user is some sort of test account or similar.

Even though it is not technically complex to allow multiple user accounts for one platform it creates complexity elsewhere.

Yeah good point. Makes sense to me!

@mattyg mattyg reopened this May 18, 2022
@kristoferlund kristoferlund moved this to Icebox / future features in Praise Development Apr 3, 2023
@github-project-automation github-project-automation bot moved this from Icebox / future features to Done in Praise Development Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants