Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to change endDate of last period #375

Closed
mattyg opened this issue May 11, 2022 · 0 comments · Fixed by #365
Closed

Unable to change endDate of last period #375

mattyg opened this issue May 11, 2022 · 0 comments · Fixed by #365
Assignees
@mattyg
Labels
api bug Something isn't working

Comments

@mattyg
Copy link
Collaborator

mattyg commented May 11, 2022

When changing the endDate of the last period, an error is displayed: "Date change only allowed on last period".

I broke the feature during this refactor: https://github.com/CommonsBuild/praise/blob/8886fc9ff48766a1c10cdf0188a0a54e7f6d4363/packages/api/src/period/utils.ts
@mattyg mattyg added bug Something isn't working api labels May 11, 2022
@mattyg mattyg self-assigned this May 11, 2022
@mattyg mattyg changed the title Unable to change endDate of latest period Unable to change endDate of last period May 11, 2022
mattyg added a commit that referenced this issue May 11, 2022
@mattyg
fix(api): fix issue where an error is displayed when attempting to ch…
ddddc4d 
…ange the endDate of the last period (see #375)
@mattyg mattyg mentioned this issue May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattyg mattyg

Labels
api bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/user event log givepraise/praise
1 participant
@mattyg