linux: ignore errors creating /dev/console

ignore errors if the file cannot be created as it might already exist. We are anyway going to create a mount on top of it and we'll catch possible errors during the mount itself. Closes: containers#150 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe · Oct 29, 2019 · af00deb · af00deb
1 parent d73f362
commit af00deb
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/libcrun/linux.c b/src/libcrun/linux.c
@@ -1863,7 +1863,10 @@ libcrun_set_terminal (libcrun_container_t *container, libcrun_error_t *err)
 
   ret = write_file ("/dev/console", NULL, 0, err);
   if (UNLIKELY (ret < 0))
-    return ret;
+    {
+      /* Ignore errors if the file creation fails.  */
+      crun_error_release (err);
+    }
 
   ret = do_mount (container, slave, "/dev/console", "devpts", MS_BIND, NULL, 0, err);
   if (UNLIKELY (ret < 0))