Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AB-0001]: added web ui for redis docker-compose.dev.yaml #260

Merged

Conversation

OleksandrKucherenko
Copy link

What kind of change does this PR introduce?

Improvements:

  • added npm script to run the docker-compose for local development. npm run dev:docker
  • added volta pin to latest node LTS version 20.17.0 (lts/iron)
  • added Redis web UI for the developer so that we can check the Redis state in a nice way
  • switch docker images to the latest/alpine versions, which have much smaller sizes of docker images (save some space)

Why was this change needed?

It makes setup for local development easier.

Copy link

vercel bot commented Sep 26, 2024

@alexkucherenko is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

@OleksandrKucherenko OleksandrKucherenko changed the title [AB0001] added web ui for redis docker-compose.dev.yaml [AB-0001] added web ui for redis docker-compose.dev.yaml Sep 28, 2024
@OleksandrKucherenko OleksandrKucherenko changed the title [AB-0001] added web ui for redis docker-compose.dev.yaml [AB-0001]: added web ui for redis docker-compose.dev.yaml Sep 28, 2024
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
docker-compose.dev.yaml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@jamesread
Copy link
Collaborator

Hey @OleksandrKucherenko , thanks very much for your first PR. I've added some comments as a code review, could you reply to those please? Thanks.

@OleksandrKucherenko OleksandrKucherenko force-pushed the AB0001-developer-environment branch 3 times, most recently from 2e5231d to d75540a Compare October 5, 2024 19:58
@jamesread jamesread merged commit 76cc074 into gitroomhq:main Oct 9, 2024
4 of 6 checks passed
@jamesread
Copy link
Collaborator

Thank you very much @OleksandrKucherenko ! Great PR, thanks for your patience!

@OleksandrKucherenko OleksandrKucherenko deleted the AB0001-developer-environment branch October 12, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants