bugfix: Add Loading component in MediaBox #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After clicking the upload button for the first time, the Loading component replaces the button until the media upload is finished
|
@wangc9 is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
|
Awesome! I will check it! |
|
@wangc9 I have checked the PR, but it doesn't work well. |
When media is being loaded by SWR, the Loading component is shown instead of directly displaying the "no media" page
|
@nevo-david That's a really good point. I've now changed it so that the Loading component will also show when the box is reading media from the database. So now, the "no media" page will only show when there is nothing in the database. If there is something, however, the Loading component will show until all the media have been retrieved from the database. |
|
@wangc9 Heya, it's been a few months, what did you intend to do with this PR? Thanks! |
jamesread
changed the title
|
@wangc9 ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fix 🐛 Bug Report: Add a loading in the media uploader #139, after clicking the upload button for the first time, the Loading component replaces the button until the media upload is finished.