Enable Python 3.8 and 3.9 on M1 runners #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were excluded in 9ad28c3 (gitpython-developers#1817) due to actions/setup-python#808, which was later fixed by actions/python-versions#259. Because Python 3.7 has been end-of-life for a while, it is very unlikely to have AArch64 builds added in python-versions for use on GitHub Actions CI runners (preinstalled or via setup-python).
|
Thank you very much.
I'd definitely like that and appreciate your thinking, let's use resources effectively where we can. A separate PR will be easier for me to handle as I can wrap up this one then. |
Byron
approved these changes
Jul 24, 2024
I've opened #1946 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were excluded in 9ad28c3 (#1817) due to actions/setup-python#808, which was later fixed by actions/python-versions#259.
Because Python 3.7 has been end-of-life for a while, it is very unlikely to have AArch64 builds added in
python-versionsfor use on GitHub Actions CI runners (preinstalled or viasetup-python).This doesn't remove any jobs, so it contributes to the gradually increasing number of CI jobs, and the operating system with the most jobs that run the whole test suite is macOS, which is also the operating system for which the rate limits on runner usage (effectively, how many jobs can be run at the same time) are the most stringent. The effect is smaller than one might think, just because the M1 runners are so fast.
Nonetheless, it may make sense to remove some or even all
macos-13jobs. The main practical difference is not the operating system version but the architecture, and the correctness of GitPython doesn't seem to be highly dependent on the architecture it is run on. For example, although #1826 did not include a test job emulating the big-endian s390x architecture, in my local testing in Alpine Linux for s390x running in a Docker container leveraging QEMU to emulate that architecture, all tests passed. (I did not run the performance tests, which would be too slow. Also, to clarify, I have not repeated this testing recently or attempted to run fuzz tests in that setup, just noting what the situation was as of #1826.)If everything is working here then I could open another PR to remove at least some of the
macos-13jobs. (If the number of jobs is considered excessive already, I could push another commit to this PR that does it.) Or that could wait until later, such as when deciding whether/when to remove Python 3.7 jobs, or when deciding what if anything to remove when adding Python 3.13 jobs (either experimental ones to test the beta, or when it is released).