Ports view improvement #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
commented
Jul 15, 2022
| return; | ||
| } | ||
| const isPortsViewExperimentEnable = vscode.workspace.getConfiguration('gitpod.experimental.portsView').get<boolean>('enabled'); | ||
| vscode.commands.executeCommand('setContext', 'gitpod.portsView.visible', isPortsViewExperimentEnable); |
There was a problem hiding this comment.
We use setContext since config will not reflect to changes sometimes.
enabled=false and change to true but Ports view not shown
|
Just merge this into gp-code 🛹 , this minor fixes is ok to push directly to main as the feature is still experimental |
jeanp413
approved these changes
Jul 15, 2022
mustard-mh
force-pushed
the
hw/port-view
branch
4 times, most recently
from
6bd3de8 to
659daf8
Compare
mustard-mh
commented
Jul 18, 2022
|
@mustard-mh if you think this is ready just merge it |
|
I tested it in preview env, and it works well, going to merge this PR. Thank you @jeanp413 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes gitpod-io/gitpod#11154
Improved things
truein insider vscodeShowNot going to do it, sincePortstab on startup without focusTerminalneeds to be the default selectionTry it outnotification while users are using the previousRemote ExplorerRemote Exploreronce we enabled experimental featureCHANGELOGas a part of Epic Epic: In Product Changelog - VS Code only gitpod#7537, we will continue this hereHow to Test
latest codeas IDEgitpod.experimental.portsView.enabledtofalse(since its default value istruein latest code)Remote ExplorerPortsview will be focused after 2 secondRemote Explorerwill dismissSee also things improved above