Skip to content

Commit

Permalink
Use separate event loop for opened tabs
Browse files Browse the repository at this point in the history
  • Loading branch information
JanKoehnlein committed May 21, 2021
1 parent faa8266 commit 37f3cee
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions src/vs/base/browser/dom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1218,13 +1218,9 @@ export function windowOpenNoOpener(url: string): void {
* See https://mathiasbynens.github.io/rel-noopener/
*/
export function windowOpenNoOpenerWithSuccess(url: string): boolean {
const newTab = window.open();
if (newTab) {
newTab.close();
window.open(url, '_blank', 'noopener');
return true;
}
return false;
// see https://github.com/gitpod-io/gitpod/issues/4266
window.open(url, '_blank', 'noopener');
return true;
}

export function animate(fn: () => void): IDisposable {
Expand Down

0 comments on commit 37f3cee

Please sign in to comment.