Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-daemon] Remove stray "cannot write limit" errors #9995

Merged
merged 1 commit into from
May 13, 2022
Merged

[ws-daemon] Remove stray "cannot write limit" errors #9995

merged 1 commit into from
May 13, 2022

Conversation

csweichel
Copy link
Contributor

Description

Removes stray "cannot write limit" from ws-daemon's IO limiter.
Notice the empty "line" in the warning below:

{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","error":"write /mnt/node-cgroups/blkio/kubepods/burstable/pod218cffe4-64a5-457a-8027-184afd8c5896/e407d0384db46e299febd26c6de18f7a1397cba52e92e9bcca9e2963e3b2f849/blkio.throttle.read_iops_device: invalid argument","level":"warning","limitPath":"/mnt/node-cgroups/blkio/kubepods/burstable/pod218cffe4-64a5-457a-8027-184afd8c5896/e407d0384db46e299febd26c6de18f7a1397cba52e92e9bcca9e2963e3b2f849/blkio.throttle.read_iops_device","line":"","message":"cannot write limit","serviceContext":{"service":"ws-daemon","version":"commit-57d2b4cc75ac7c5bf27d6bafe6e6edc5e4f8f07f"},"severity":"WARNING","time":"2022-05-13T09:09:12Z"}

How to test

Run ws-daemon

Release Notes

[ws-daemon] Remove stray IO limiter warnings

@csweichel csweichel marked this pull request as ready for review May 13, 2022 09:46
@csweichel csweichel requested a review from a team May 13, 2022 09:46
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 13, 2022
utam0k
utam0k approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@roboquat roboquat merged commit 40491e6 into main May 13, 2022
@roboquat roboquat deleted the cw/wsdaemon-write-limit branch May 13, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csweichel @utam0k @roboquat