[workspacekit] improve logging when not able to connect to daemon #9951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
approved these changes
May 11, 2022
jenting
reviewed
May 12, 2022
| @@ -397,7 +397,7 @@ var ring1Cmd = &cobra.Command{ | |||
|
|
|||
| client, err := connectToInWorkspaceDaemonService(ctx) | |||
| if err != nil { | |||
| log.WithError(err).Error("cannot connect to daemon") | |||
| log.WithError(err).Error("cannot connect to daemon from ring1") | |||
There was a problem hiding this comment.
Thanks for your kindly explanation @utam0k, attach the diagram for future reference
|
/hold until @jenting approve this PR |
|
/werft run 👍 started the job as gitpod-build-pavel-ring-logging.1 |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves logging to better understand when we fail to connect to daemon from workspacekit.
Related Issue(s)
Related to #9835
How to test
Release Notes
Documentation