Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] fix restore from snapshot not working #9943

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented May 11, 2022

Description

Fixed restore from snapshot not working due to not handling composite initializers correctly.

Related Issue(s)

Fixes #9244

How to test

Open this repo in gitpod: https://github.com/jldec/date-plus
Create snapshot.
Open new repo from that snapshot.

Release Notes

[ws-daemon] fix restore from snapshot not working

Documentation

@sagor999
Copy link
Contributor Author

sagor999 commented May 11, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-pavel-9244.4
(with .werft/ from main)

@sagor999 sagor999 changed the title wip [ws-daemon] fix restore from snapshot not working May 11, 2022
@sagor999 sagor999 marked this pull request as ready for review May 11, 2022 21:51
@sagor999 sagor999 requested a review from a team May 11, 2022 21:51
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 11, 2022
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm

@roboquat roboquat merged commit c1cd9bb into main May 12, 2022
@roboquat roboquat deleted the pavel/9244 branch May 12, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error opening snapshot on some github repos - cannot initialize workspace: did not find snapshot
3 participants