Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move java task as a command #9927

Merged
merged 1 commit into from
May 11, 2022
Merged

Move java task as a command #9927

merged 1 commit into from
May 11, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented May 11, 2022

Description

This PR makes gradle build not run by default, and instead you have to explicitly that you want to run by pressing enter
or setting environment variable RUN_GRADLE_TASK

Related Issue(s)

Related #9874

How to test

  1. Open this PR in gitpod.io using https://gitpod.io/#https://github.com/gitpod-io/gitpod/pull/9927
  2. You can see this prompt, and press enter will continue gradle build
    image
  3. Setting Environment Variables RUN_GRADLE_TASK for gitpod-io/gitpod repo
  4. re open https://gitpod.io/#https://github.com/gitpod-io/gitpod/pull/9927
  5. you will see gradle build is automatic start
    image

Release Notes

NONE

Documentation

  • /werft no-preview

@mustard-mh
Copy link
Contributor Author

mustard-mh commented May 11, 2022

/werft run

👍 started the job as gitpod-build-hw-move-java.1
(with .werft/ from main)

@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@mustard-mh mustard-mh marked this pull request as ready for review May 11, 2022 10:20
@mustard-mh mustard-mh requested a review from akosyakov May 11, 2022 10:22
@felladrin
Copy link
Contributor

Looking good!

When the workspace starts, du -d 1 -h /workspace outputs the following:

image

About 3 minutes later after Pressing Enter, the Java task completes:

image

And this is the result of du -d 1 -h /workspace after it:

image

I think the exchange of 5.9GB in prebuilds for 3 minutes after the IDE starts is worth it, considering that even who develops the JetBrains IDEs Plugins will somtimes want to skip this task.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@felladrin
Copy link
Contributor

I've also noticed the workspace loading faster, when opening this PR.

And when using RUN_GRADLE_TASK to automatically start the task, it was all ready 2 minutes after the IDE finished loading (due to the command start executing before the IDE shows up).

@roboquat roboquat merged commit dd2d2c5 into main May 11, 2022
@roboquat roboquat deleted the hw/move-java branch May 11, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants