Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helm chart #9858

Merged
merged 3 commits into from
May 11, 2022
Merged

Remove helm chart #9858

merged 3 commits into from
May 11, 2022

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented May 9, 2022

Description

This PR removes the helm chart. Now that we're fully migrated to the installer, we can finally get rid of that thing.

This PR also (temporarily removes) the contrib/docker directory, as that was sitting on the helm chart. @corneliusludmann what should we do here?

Fixes

#9843

How to test

Use the installer instead :)

Release Notes

Fully removed the deprecated helm charts.

Documentation

https://github.com/gitpod-io/website/issues/2002

@csweichel csweichel requested review from a team May 9, 2022 07:56
@csweichel csweichel marked this pull request as draft May 9, 2022 07:56
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team and removed size/XXL labels May 9, 2022
@geropl
Copy link
Member

geropl commented May 9, 2022

@csweichel AFAIK this is blocked by #9843. Not a big one, but should be tackled beforehand. 😉

@csweichel
Copy link
Contributor Author

That's part of this PR - albeit a tad broken. Working on a fix.

@csweichel csweichel force-pushed the cw/remove-helm branch 2 times, most recently from a3044a9 to 4c32a11 Compare May 9, 2022 08:04
@meysholdt
Copy link
Member

This fixes #9842

This PR also (temporarily removes) the contrib/docker directory, as that was sitting on the helm chart. @corneliusludmann what should we do here?

Also asking that question here.

@corneliusludmann
Copy link
Contributor

contrig/docker can be removed entirely. It's sufficient to have this in the Git history.

cc @Pothulapati

@Pothulapati
Copy link
Contributor

Pothulapati commented May 9, 2022

Agree with @corneliusludmann, I can use it from the git history to build a similar thing with kots 👍🏼

@csweichel csweichel force-pushed the cw/remove-helm branch 2 times, most recently from 3fab697 to cd49418 Compare May 10, 2022 12:23
@csweichel csweichel marked this pull request as ready for review May 10, 2022 12:48
@geropl
Copy link
Member

geropl commented May 11, 2022

Sorry for blocking, but I'd love to understand the inti script refactor. I have a time slot at 5PM to do so, and can ✔️ then. 👍

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see this go! 👋

(I have a couple of questions wrt to init scripts, but that is out of scope here 👍 )

@roboquat roboquat merged commit 7b86b04 into main May 11, 2022
@roboquat roboquat deleted the cw/remove-helm branch May 11, 2022 15:40
@meysholdt meysholdt mentioned this pull request May 11, 2022
5 tasks
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label May 12, 2022
@roboquat roboquat added the deployed: webapp Meta team change is running in production label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants