Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change workspace integration test from core-dev to preview environment #9854

Merged
merged 2 commits into from
May 12, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented May 9, 2022

Description

Since the preview environment is now the default environment that the werft job deploy to.
Change the workspace integration test being able to run against preview environment.

The werft job is still running in the core-dev context werft namespace though.
I did not find a way to make it possible that werft job being able to run on another context unless we run the integration test job by manually applies the yaml manifest to preview-environment context default namespace within the werft job.
But it also means we have to copy the related secrets from core-dev to preview environment context.

Therefore, I give up to find a simple way to make the integration test pod being able to run in preview-environment context. Instead, make the integration test being able to run on any machine against the preview-environment context default namespace. But it also mean that we need to fix these two integration tests #9953 since previously design only allow the test be passed when the integration test pod running within the same cluster. (I believe the integration test should be passed regardless of the environment in which it is executed).

In general, it runs go test ... in core-dev context werft namespace against preview-environment context default namespace. It's like what we run go test .. locally against preview-environmentcontextdefault` namespace.

Related Issue(s)

Fixes #9749

How to test

werft run github -j .werft/workspace-run-integration-tests.yaml

Reference werft job https://werft.gitpod-dev.com/job/gitpod-custom-jenting-change-workspace-nightly-9749.55
Reference slack notification https://gitpod.slack.com/archives/C03E52788SU/p1652399601400079

Release Notes

None

Documentation

N/A

@jenting jenting force-pushed the jenting/change-workspace-nightly-9749 branch 18 times, most recently from 39bcb07 to d9d30d8 Compare May 11, 2022 03:58
@jenting jenting marked this pull request as ready for review May 11, 2022 05:04
@jenting jenting requested a review from a team May 11, 2022 05:04
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 11, 2022
@princerachit
Copy link
Contributor

@jenting can you describe the changes you made in this PR. I see you removed a file why so? What was the reason of getting rid of the args and other fields in the YAML?

@jenting
Copy link
Contributor Author

jenting commented May 11, 2022

@jenting can you describe the changes you made in this PR. I see you removed a file why so? What was the reason of getting rid of the args and other fields in the YAML?

I've update the PR description, hope it clear to understand 🙏

@jenting
Copy link
Contributor Author

jenting commented May 11, 2022

/hold

@csweichel
Copy link
Contributor

csweichel commented May 12, 2022

I believe the integration test should be passed regardless of the environment in which it is executed

💯 🎯

@jenting jenting force-pushed the jenting/change-workspace-nightly-9749 branch 6 times, most recently from c28cd5f to 63bf642 Compare May 12, 2022 10:46
@jenting
Copy link
Contributor Author

jenting commented May 12, 2022

/unhold

Ready to review

@jenting
Copy link
Contributor Author

jenting commented May 12, 2022

/werft run

👍 started the job as gitpod-build-jenting-change-workspace-nightly-9749.68
(with .werft/ from main)

@jenting jenting force-pushed the jenting/change-workspace-nightly-9749 branch from 63bf642 to e38f51f Compare May 12, 2022 12:17
@jenting
Copy link
Contributor Author

jenting commented May 12, 2022

/werft run

👍 started the job as gitpod-build-jenting-change-workspace-nightly-9749.70
(with .werft/ from main)

Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for minor nit.

/hold

feel free to remove hold when\if addressed that nit.

.werft/workspace-run-integration-tests.yaml Outdated Show resolved Hide resolved
@jenting
Copy link
Contributor Author

jenting commented May 12, 2022

/unhold

@roboquat roboquat merged commit 81c5a50 into main May 12, 2022
@roboquat roboquat deleted the jenting/change-workspace-nightly-9749 branch May 12, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XL team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change workspace integration tests nightly from core-dev to preview environment
5 participants