-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change workspace integration test from core-dev to preview environment #9854
Conversation
39bcb07
to
d9d30d8
Compare
@jenting can you describe the changes you made in this PR. I see you removed a file why so? What was the reason of getting rid of the args and other fields in the YAML? |
I've update the PR description, hope it clear to understand 🙏 |
/hold |
💯 🎯 |
c28cd5f
to
63bf642
Compare
/unhold Ready to review |
/werft run 👍 started the job as gitpod-build-jenting-change-workspace-nightly-9749.68 |
Signed-off-by: JenTing Hsiao <[email protected]>
63bf642
to
e38f51f
Compare
/werft run 👍 started the job as gitpod-build-jenting-change-workspace-nightly-9749.70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for minor nit.
/hold
feel free to remove hold when\if addressed that nit.
Signed-off-by: JenTing Hsiao <[email protected]>
/unhold |
Description
Since the preview environment is now the default environment that the werft job deploy to.
Change the workspace integration test being able to run against preview environment.
The werft job is still running in the
core-dev
contextwerft
namespace though.I did not find a way to make it possible that werft job being able to run on another context unless we run the integration test job by manually applies the yaml manifest to
preview-environment
contextdefault
namespace within the werft job.But it also means we have to copy the related secrets from
core-dev
topreview environment
context.Therefore, I give up to find a simple way to make the integration test pod being able to run in
preview-environment
context. Instead, make the integration test being able to run on any machine against thepreview-environment
contextdefault
namespace. But it also mean that we need to fix these two integration tests #9953 since previously design only allow the test be passed when the integration test pod running within the same cluster. (I believe the integration test should be passed regardless of the environment in which it is executed).In general, it runs
go test ...
incore-dev
contextwerft
namespace againstpreview-environment
contextdefault
namespace. It's like what we rungo test ..
locally against preview-environmentcontext
default` namespace.Related Issue(s)
Fixes #9749
How to test
Reference werft job https://werft.gitpod-dev.com/job/gitpod-custom-jenting-change-workspace-nightly-9749.55
Reference slack notification https://gitpod.slack.com/archives/C03E52788SU/p1652399601400079
Release Notes
Documentation
N/A