Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intellij to avoid generating large gradle #9830

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented May 6, 2022

Description

Right now, Gitpod repo prebuild will generate a .grandle folder with 12G of storage. This PR remove intellij in .gitpod.yml file to avoid pre-indexing of intellij, to save time of download rebuild and workspace storage and save time for snapshot etc.

image

Related Issue(s)

Fixes #

How to test

  1. Start Gitpod with this branch https://gitpod.io/#https://github.com/gitpod-io/gitpod/tree/hw/remove-intellij or with prebuild one https://gitpod.io/#prebuild/https://github.com/gitpod-io/gitpod/tree/hw/remove-intellij
  2. Exec du -d 1 -h /workspace, you'll see something like these below, .gradle folder from 12G to 6G
36M     /workspace/.cache
0       /workspace/.cargo
4.0K    /workspace/.config
396K    /workspace/.gitpod
5.9G    /workspace/.gradle
1.4G    /workspace/gitpod
30M     /workspace/go
446M    /workspace/.vscode-remote
7.8G    /workspace

Another part of .gradle is gen by https://github.com/gitpod-io/gitpod/blob/main/.gitpod.yml#L38-L42 we have other plan about it, like move JetBrains related to another repo, see internal chat

Release Notes

NONE

Documentation

  • /werft without-preview=true

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@mustard-mh mustard-mh requested a review from akosyakov May 6, 2022 14:13
@felladrin
Copy link
Contributor

@akosyakov / @mustard-mh
Should this PR be blocked till the end of #9874 investigation?

@akosyakov
Copy link
Member

I would rather close it for now. Ideally we should keep everything but make it perform.

@csweichel
Copy link
Contributor

It will still take a while until prebuilds of this size perform better. Can we remove it for now to not pay that cost for every Gitpodder (very few of which will actually benefit from this cache?)

@felladrin
Copy link
Contributor

felladrin commented May 10, 2022

I realized @mustard-mh was right in saying that #9874 is about a different problem.

So I've opened a workspace using this URL (https://gitpod.io/#prebuild/https://github.com/gitpod-io/gitpod/tree/hw/remove-intellij), which should require the backend to fully download IntelliJ IDEA and it actually loaded fast enough. (I had IntelliJ IDEA selected as editor in Gitpod Preferences)
I've noticed the build of Gateway Plugin took longer, though. But as Chris mentioned above, it's something that only a few benefits people from being cached.

So I vote for merging this.


Suggestion: we could also remove the Goland IDE (as it downloads quickly, when needed):

jetbrains:
  goland:
    prebuilds:
      version: stable

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roboquat roboquat merged commit 8f11ecc into main May 10, 2022
@roboquat roboquat deleted the hw/remove-intellij branch May 10, 2022 10:01
@akosyakov
Copy link
Member

akosyakov commented May 10, 2022

Sure we can remove everything, but what is the point if we cannot dogfood our own things and learn from it 🤷‍♂️

@akosyakov
Copy link
Member

@easyCZ Do you keep using GoLand and benefit from indexing?

@easyCZ
Copy link
Member

easyCZ commented May 10, 2022

@akosyakov It has been faster to start-up, but not significantly because GoLand seems to re-index on workspace startup

@akosyakov
Copy link
Member

@easyCZ Do you use stable GoLand? we disabled indexing for latest.

@easyCZ
Copy link
Member

easyCZ commented May 10, 2022

I'm on EAP, themes and a couple of other things are glitchy for me on Stable.

@akosyakov
Copy link
Member

akosyakov commented May 10, 2022

@easyCZ new stable was released 2 weeks ago which is the same as EAP now (actually should be more up to date)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants