-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove intellij to avoid generating large gradle #9830
Conversation
|
@akosyakov / @mustard-mh |
I would rather close it for now. Ideally we should keep everything but make it perform. |
It will still take a while until prebuilds of this size perform better. Can we remove it for now to not pay that cost for every Gitpodder (very few of which will actually benefit from this cache?) |
I realized @mustard-mh was right in saying that #9874 is about a different problem.
So I've opened a workspace using this URL (https://gitpod.io/#prebuild/https://github.com/gitpod-io/gitpod/tree/hw/remove-intellij), which should require the backend to fully download IntelliJ IDEA and it actually loaded fast enough. (I had IntelliJ IDEA selected as editor in Gitpod Preferences) So I vote for merging this. Suggestion: we could also remove the Goland IDE (as it downloads quickly, when needed): jetbrains:
goland:
prebuilds:
version: stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sure we can remove everything, but what is the point if we cannot dogfood our own things and learn from it 🤷♂️ |
@easyCZ Do you keep using GoLand and benefit from indexing? |
@akosyakov It has been faster to start-up, but not significantly because GoLand seems to re-index on workspace startup |
@easyCZ Do you use stable GoLand? we disabled indexing for latest. |
I'm on EAP, themes and a couple of other things are glitchy for me on Stable. |
@easyCZ new stable was released 2 weeks ago which is the same as EAP now (actually should be more up to date) |
Description
Right now, Gitpod repo prebuild will generate a .grandle folder with 12G of storage. This PR remove
intellij
in.gitpod.yml
file to avoid pre-indexing of intellij, to save time of download rebuild and workspace storage and save time for snapshot etc.Related Issue(s)
Fixes #
How to test
du -d 1 -h /workspace
, you'll see something like these below,.gradle
folder from 12G to 6GAnother part of .gradle is gen by https://github.com/gitpod-io/gitpod/blob/main/.gitpod.yml#L38-L42 we have other plan about it, like move JetBrains related to another repo, see internal chat
Release Notes
Documentation