Fix Supervisor sending empty port names and descriptions #9797

felladrin · 2022-05-05T16:17:16Z

Description

Currently, supervisor send empty name and description of ports to editor(code) which make tooltip in code not works (see also #9262 (comment)).

This PR fix it

Related Issue(s)

#9262 (comment)

How to test

Note that port with range will work only when ports are opened

Init with .gitpod.yml

Open a repo which contains ports define in .gitpod.yml with name and descripts like this one https://github.com/mustard-mh/test/tree/hw/port-name
Choose VSCode as IDE in preference
Start workspace with that repo https://vn-fix-emp45629038ff.preview.gitpod-dev.com/#https://github.com/mustard-mh/test/tree/hw/port-name
Check if port explorer got name and description with port with tooltip (hover)

Watch .gitpod.yml

Change .gitpod.yml in your workspace, the tooltip in port explorer should reflect to yml file

Image

Release Notes

Fix port name and description not showing up on Gitpod VS Code Extension sidebar.

Documentation

felladrin · 2022-05-05T21:30:35Z

The current code is working, as seen in here. What is wrong is that it's not reading the the .gitpod.yml file as it should.

components/supervisor/pkg/ports/ports.go

felladrin · 2022-05-23T15:10:40Z

@mustard-mh, just to let you know I'll add more details to the PR description soon, to make it clear what's the problem and what I have already tried to fix it. Hopefully you can help to find the cause ^^
(It stopped working somewhen in the last 3 months.)

iQQBot

LGTM Thanks @mustard-mh

akosyakov · 2022-05-24T06:24:03Z

Does it work for port ranges too?

mustard-mh · 2022-05-24T06:34:45Z

Does it work for port ranges too?

I think it will after the new push, waiting for new build to test 👍

mustard-mh · 2022-05-24T06:42:13Z

Ranges will work only when ports are opened. cc @akosyakov

akosyakov · 2022-05-24T06:44:57Z

Hm, there is no name in the remote explorer view. It is a bug in vscode web. Could you fix it there as well? 🙏

mustard-mh · 2022-05-24T06:47:11Z

Hm, there is no name in a view. It is a bug in vscode web. Could you fit there as well? 🙏

What name in a view means?

1111 should be range: 1111 in the screen capture?

akosyakov · 2022-05-24T06:50:46Z

but it is another follow up PR, this one is good 👍

akosyakov · 2022-05-24T06:54:52Z

components/supervisor/pkg/ports/ports.go

@@ -411,6 +411,11 @@ func (pm *Manager) nextState(ctx context.Context) map[uint32]*managedPort {

 		var public bool
 		config, kind, exists := pm.configs.Get(mp.LocalhostPort)
+		if exists {


I wonder why it is necessary here, configurations should be handled above at step 2, this step about served state

ah, it is for ranges?

Do we miss here anything else like visibility handling or action on expose?

It can be another PR too.

visibility (port private and public) is handled here

gitpod/components/supervisor/pkg/ports/ports.go

Line 430 in 3013055

mp.AutoExposure = pm.autoExpose(ctx, mp.LocalhostPort, public).state

Do we need to call mp.OnExposed = getOnExposedAction(config, port)? or it is handled already somewhere too?

Do we need to call mp.OnExposed = getOnExposedAction(config, port)? or it is handled already somewhere too?

added

I tested with onOpen: open-browser with ranges before and it works fine, but I don't know where is code. Add to confirm it

thank you, great 👍

maybe a commit in if will be nice, that we are handling configuration for port ranges here

roboquat added release-note do-not-merge/work-in-progress size/S labels May 5, 2022

felladrin force-pushed the vn/fix-empty-port-name-description branch 2 times, most recently from 0dc177d to 34df117 Compare May 5, 2022 18:55

akosyakov reviewed May 6, 2022

View reviewed changes

components/supervisor/pkg/ports/ports.go Outdated Show resolved Hide resolved

felladrin closed this May 10, 2022

felladrin force-pushed the vn/fix-empty-port-name-description branch from 34df117 to 98726d3 Compare May 10, 2022 13:49

roboquat added size/XS and removed size/S labels May 10, 2022

felladrin reopened this May 10, 2022

roboquat added size/S and removed size/XS labels May 10, 2022

mustard-mh self-assigned this May 18, 2022

davidwindell mentioned this pull request May 20, 2022

Ports need descriptions #3059

Closed

mustard-mh force-pushed the vn/fix-empty-port-name-description branch from 74fa049 to 98c03ec Compare May 24, 2022 05:33

roboquat added size/M and removed size/S labels May 24, 2022

mustard-mh mentioned this pull request May 24, 2022

Generated file is not assign to current file #10203

Open

3 tasks

mustard-mh marked this pull request as ready for review May 24, 2022 06:09

mustard-mh requested review from a team May 24, 2022 06:09

roboquat removed the do-not-merge/work-in-progress label May 24, 2022

github-actions bot added team: IDE team: webapp Issue belongs to the WebApp team labels May 24, 2022

iQQBot approved these changes May 24, 2022

View reviewed changes

mustard-mh force-pushed the vn/fix-empty-port-name-description branch from 98c03ec to 073b8e0 Compare May 24, 2022 06:20

mustard-mh force-pushed the vn/fix-empty-port-name-description branch from 073b8e0 to 3013055 Compare May 24, 2022 06:32

akosyakov reviewed May 24, 2022

View reviewed changes

Fix supervisor send empty port name and desc

cf43f79

mustard-mh force-pushed the vn/fix-empty-port-name-description branch from 3013055 to cf43f79 Compare May 24, 2022 07:13

easyCZ approved these changes May 24, 2022

View reviewed changes

roboquat merged commit 37a1d8e into main May 24, 2022

roboquat deleted the vn/fix-empty-port-name-description branch May 24, 2022 07:29

mustard-mh mentioned this pull request May 24, 2022

Add comment for port ranges #10207

Merged

1 task

roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Supervisor sending empty port names and descriptions #9797

Fix Supervisor sending empty port names and descriptions #9797

felladrin commented May 5, 2022 •

edited by mustard-mh

Loading

felladrin commented May 5, 2022

felladrin commented May 23, 2022

iQQBot left a comment

akosyakov commented May 24, 2022

mustard-mh commented May 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mustard-mh commented May 24, 2022

akosyakov commented May 24, 2022 •

edited

Loading

mustard-mh commented May 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented May 24, 2022 •

edited

Loading

akosyakov May 24, 2022 •

edited

Loading

akosyakov May 24, 2022

akosyakov May 24, 2022

mustard-mh May 24, 2022

akosyakov May 24, 2022 •

edited

Loading

mustard-mh May 24, 2022 •

edited

Loading

akosyakov May 24, 2022

akosyakov May 24, 2022

Fix Supervisor sending empty port names and descriptions #9797

Fix Supervisor sending empty port names and descriptions #9797

Conversation

felladrin commented May 5, 2022 • edited by mustard-mh Loading

Description

Related Issue(s)

How to test

Init with .gitpod.yml

Watch .gitpod.yml

Release Notes

Documentation

felladrin commented May 5, 2022

felladrin commented May 23, 2022

iQQBot left a comment

Choose a reason for hiding this comment

akosyakov commented May 24, 2022

mustard-mh commented May 24, 2022 • edited by werft-gitpod-dev-com bot Loading

mustard-mh commented May 24, 2022

akosyakov commented May 24, 2022 • edited Loading

mustard-mh commented May 24, 2022 • edited by werft-gitpod-dev-com bot Loading

akosyakov commented May 24, 2022 • edited Loading

akosyakov May 24, 2022 • edited Loading

Choose a reason for hiding this comment

akosyakov May 24, 2022

Choose a reason for hiding this comment

akosyakov May 24, 2022

Choose a reason for hiding this comment

mustard-mh May 24, 2022

Choose a reason for hiding this comment

akosyakov May 24, 2022 • edited Loading

Choose a reason for hiding this comment

mustard-mh May 24, 2022 • edited Loading

Choose a reason for hiding this comment

akosyakov May 24, 2022

Choose a reason for hiding this comment

akosyakov May 24, 2022

Choose a reason for hiding this comment

felladrin commented May 5, 2022 •

edited by mustard-mh

Loading

mustard-mh commented May 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented May 24, 2022 •

edited

Loading

mustard-mh commented May 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented May 24, 2022 •

edited

Loading

akosyakov May 24, 2022 •

edited

Loading

akosyakov May 24, 2022 •

edited

Loading

mustard-mh May 24, 2022 •

edited

Loading