Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content-service] Fix backup restore #9732

Merged
merged 2 commits into from
May 4, 2022
Merged

[content-service] Fix backup restore #9732

merged 2 commits into from
May 4, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 3, 2022

Description

Partial revert of #9589. Only reverts the restore part.

How to test

  • Open a workspace. In the terminal execute:
touch basic
sudo touch root-file
touch executable-file
chmod +x executable-file
touch suid-file
chmod 2555 suid-file
mkdir suid-directory
chmod g+s suid-directory
  • Check the output of ls -lat, should be similar to
drwxr-x--- 8 gitpod gitpod 4096 Apr 28 17:31 .
-r-xr-sr-x 1 gitpod gitpod    0 Apr 28 17:31 suid-file
drwxr-sr-x 2 gitpod gitpod    6 Apr 28 17:31 suid-directory
-rwxr-xr-x 1 gitpod gitpod    0 Apr 28 17:30 executable-file
-rw-r--r-- 1 root   root      0 Apr 28 17:30 root-file
-rw-r--r-- 1 gitpod gitpod    0 Apr 28 17:30 basic
  • Stop and open the workspace
  • Open a terminal and run ls -lat
  • Compare the outputs

Release Notes

[content-service] Fix backup restoration

xref #9730

@aledbf aledbf requested a review from mustard-mh May 3, 2022 19:45
@aledbf aledbf mentioned this pull request May 3, 2022
@aledbf aledbf marked this pull request as ready for review May 3, 2022 20:39
@aledbf aledbf requested review from a team May 3, 2022 20:39
@aledbf aledbf requested review from csweichel and akosyakov as code owners May 3, 2022 20:39
@aledbf aledbf requested a review from a team May 3, 2022 20:39
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels May 3, 2022
@aledbf aledbf changed the title [content-service] Fix backup restoration [content-service] Fix backup restore May 3, 2022
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised, plus, will unblock gitpod-staging.com.

CC: @geropl @jankeromnes

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, now it works

@geropl
Copy link
Member

geropl commented May 4, 2022

Testing...

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, awesome!

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 2e7526f into main May 4, 2022
@roboquat roboquat deleted the aledbf/dec branch May 4, 2022 08:28
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants