Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] Improve IDE readiness probe #9706

Merged
merged 1 commit into from
May 3, 2022
Merged

[supervisor] Improve IDE readiness probe #9706

merged 1 commit into from
May 3, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 2, 2022

Description

  • Reduce test window
  • Properly close body response

Release Notes

[supervisor] Improve IDE readiness probe

@aledbf
Copy link
Member Author

aledbf commented May 3, 2022

/werft run

👍 started the job as gitpod-build-aledbf-ide.1
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review May 3, 2022 00:18
@aledbf aledbf requested a review from a team May 3, 2022 00:18
@aledbf aledbf requested a review from jeanp413 May 3, 2022 02:07
@jeanp413
Copy link
Member

jeanp413 commented May 3, 2022

Status readiness for vscode browser is broken now 😅
I think only this should be inside the loop, response parsing etc should be after breaking the loop

	resp, err := client.Get(url)
	if err != nil {
		log(...)
	}

	if resp.StatusCode == http.StatusOK {
              break;
	}

@aledbf aledbf force-pushed the aledbf/ide branch 2 times, most recently from 32f4065 to 079cfde Compare May 3, 2022 10:39
@aledbf
Copy link
Member Author

aledbf commented May 3, 2022

@jeanp413 ready for another review

Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for vscode browser, desktop and jetbrains

@roboquat roboquat merged commit 2037329 into main May 3, 2022
@roboquat roboquat deleted the aledbf/ide branch May 3, 2022 12:42
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants