Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[agent-smith] Remove egress check feature #9689

Merged
merged 2 commits into from
May 4, 2022
Merged

[agent-smith] Remove egress check feature #9689

merged 2 commits into from
May 4, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 2, 2022 •
edited
Loading

Description

In scenarios where bandwidth limit should be implemented, use the CNI bandwidth plugin and a custom default template in Gitpod:

  default.yaml: |
    metadata:
      annotations:
        kubernetes.io/ingress-bandwidth: 200M
        kubernetes.io/egress-bandwidth: 200M

Release Notes

[agent-smith] Remove egress check feature

Edit: the CNI approach is also more permissive because it does not terminate the workspace

@aledbf aledbf requested a review from a team May 2, 2022 12:55
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 2, 2022
@aledbf
Copy link
Member Author

aledbf commented May 2, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-as.2
(with .werft/ from main)

@aledbf aledbf requested review from a team May 2, 2022 13:21
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels May 2, 2022
@aledbf
Copy link
Member Author

aledbf commented May 2, 2022

the second commit is required to fix a CI issue:

level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/hashicorp/golang-lru\"\n\n"

Pothulapati
Pothulapati approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on the installer side.

easyCZ
easyCZ approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only an update to go.mod for webapp which looks to be transitive. LGTM

@roboquat roboquat merged commit 64fe0d5 into main May 4, 2022
@roboquat roboquat deleted the aledbf/as branch May 4, 2022 12:29
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed: webapp Meta team change is running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Furisto Furisto Furisto approved these changes

@Pothulapati Pothulapati Pothulapati approved these changes

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note size/XL team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledbf @easyCZ @Pothulapati @Furisto @roboquat