Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the workspace integration tests that need username in DB first #9628

Merged
merged 3 commits into from
May 2, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Apr 28, 2022

Description

Fix the workspace integration tests that need a username in DB first

  • TestGitHubContexts
  • TestWorkspaceInstrumentation
  • TestGitActions

Related Issue(s)

Fixes #9627

How to test

werft run github -j .werft/workspace-integration-tests-startup-cron.yaml

Ref werft job result

Release Notes

None

Documentation

N/A

@jenting jenting requested a review from a team April 28, 2022 14:42
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 28, 2022
@jenting jenting marked this pull request as draft April 28, 2022 14:46
jenting added 3 commits May 1, 2022 15:51
Git config --user.name and git config --user.email, otherwise, git commit
would fail.

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting force-pushed the fix-TestGitActions branch from 9799b3a to 58cdcd7 Compare May 1, 2022 07:52
@jenting jenting changed the title Fix broken integration test test TestGitActions Fix the workspace integration tests that need username in DB first May 1, 2022
@jenting jenting marked this pull request as ready for review May 1, 2022 08:15
@utam0k
Copy link
Contributor

utam0k commented May 2, 2022

@jenting I couldn't run the following command to review this PR😭 Do you know how to fix it?

gitpod /workspace/gitpod (fix-TestGitActions) $ werft run github -f .werft/workspace-integration-tests-startup-cron.yaml
Error: rpc error: code = Internal desc = cannot resolve request: "rpc error: code = InvalidArgument desc = ref is empty"
tip: There seems to be a problem with your werft installation - please get in contact with whoever is operating this installation.

@jenting
Copy link
Contributor Author

jenting commented May 2, 2022

@jenting I couldn't run the following command to review this PR😭 Do you know how to fix it?

gitpod /workspace/gitpod (fix-TestGitActions) $ werft run github -f .werft/workspace-integration-tests-startup-cron.yaml
Error: rpc error: code = Internal desc = cannot resolve request: "rpc error: code = InvalidArgument desc = ref is empty"
tip: There seems to be a problem with your werft installation - please get in contact with whoever is operating this installation.

Oops, command typo. Should be -j, not -f 😅

werft run github -j .werft/workspace-integration-tests-startup-cron.yaml

Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roboquat roboquat merged commit a4ae70c into main May 2, 2022
@roboquat roboquat deleted the fix-TestGitActions branch May 2, 2022 01:07
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the workspace integration tests that need a username in DB first
3 participants