Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded privileges for server #9614

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Remove unneeded privileges for server #9614

merged 1 commit into from
Apr 28, 2022

Conversation

meysholdt
Copy link
Member

Description

A security scan highlighted that verbs "delete","deletecollection" should only be granted via k8s Roles when necessary. See the linked issue for details.

Our server component has these verbs and I assume it does not need them because I assume it's ws-manger that creates and deletes k8s services and pods. However, maybe I'm overlooking something. If I do, please close this PR.

Related Issue(s)

Fixes # https://github.com/gitpod-io/security/issues/39

How to test

Release Notes

Improved security by removing unneeded privileges from the server component.

Documentation

@meysholdt meysholdt requested a review from a team April 28, 2022 09:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 28, 2022
geropl
geropl approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely correct. We could even think about removing all permissions. But let's do that as follow-up 👍

@roboquat roboquat merged commit 82d7451 into main Apr 28, 2022
@roboquat roboquat deleted the me/priv branch April 28, 2022 10:22
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meysholdt @geropl @roboquat