Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E label filter not working #9576

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix E2E label filter not working #9576

merged 1 commit into from
Apr 27, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Apr 27, 2022 •
edited
Loading

Description

The E2E label filter is not working, we should be able to filter the test to run by labels.
Since the label filter is supported from sigs.k8s.io/[email protected],
we bump the sigs.k8s.io/e2e-framework to the latest version v0.0.6.

Related Issue(s)

#8799

How to test

# It should only run the E2E tests with label `component=workspace`.
go test -v ./... \
  -kubeconfig=/home/gitpod/.kube/config \ 
  -namespace=<namespace> \
  -labels "component=workspace" 

# It should only run the E2E tests with label `component=ws-manager`.
go test -v ./... \
  -kubeconfig=/home/gitpod/.kube/config \
  -namespace=<namespace> \
  -labels "component=ws-manager"

Release Notes

NONE

Documentation

No

@jenting
Fix E2E label filter not working
602c17a 
The label filter is supported from sigs.k8s.io/[email protected],
we bump the sigs.k8s.io/e2e-framework to the latest version v0.0.6.

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting requested a review from a team April 27, 2022 06:08
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 27, 2022
princerachit
princerachit approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@princerachit princerachit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test this but changes look good

@roboquat roboquat merged commit c31498e into main Apr 27, 2022
@roboquat roboquat deleted the fix-e2e-label-filter-not-working branch April 27, 2022 07:17
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@princerachit princerachit princerachit approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenting @princerachit @roboquat