Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[supervisor] Do not report error when the process is terminated #9572

Merged
merged 1 commit into from
Apr 27, 2022
Merged

[supervisor] Do not report error when the process is terminated #9572

merged 1 commit into from
Apr 27, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 26, 2022

Description

Internal logs https://console.cloud.google.com/errors/detail/CNiVgcfVn86fcQ?project=workspace-clusters

Release Notes

[supervisor] Do not report error when the process is terminated

@aledbf aledbf requested a review from a team April 26, 2022 22:32
@iQQBot
Copy link
Contributor

iQQBot commented Apr 27, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run no-preview

👍 started the job as gitpod-build-aledbf-signal.1
(with .werft/ from main)

iQQBot
iQQBot approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 42783dc into main Apr 27, 2022
@roboquat roboquat deleted the aledbf/signal branch April 27, 2022 03:45
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @iQQBot @roboquat