Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] fix ide option not exists bug #9541

Merged
merged 1 commit into from
Apr 27, 2022
Merged

[server] fix ide option not exists bug #9541

merged 1 commit into from
Apr 27, 2022

Conversation

mustard-mh
Copy link
Contributor

Description

Fix function chooseIDE func not cover not exists IDE id

Related Issue(s)

Fixes #

How to test

Open Gitpod with this PR, exec

cd components/server && yarn test

Release Notes

NONE

Documentation

  • /werft no-preview

@mustard-mh mustard-mh requested a review from a team April 26, 2022 08:16
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 26, 2022
@akosyakov
Copy link
Member

How to reproduce the original issue from UI?

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Apr 27, 2022 •
edited
Loading

How to reproduce the original issue from UI?

We can't. This is part of #9467 RP's commit. cc @akosyakov

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Apr 27, 2022 •
edited
Loading

I wrote function chooseIDE first and add test cases. So test cases can be passed of course. But other test cases I didn't cover may not pass (like this🙈).

How can we avoid this to happen? Write test cases first to drive code? Ask someone else to input more test cases?

cc @akosyakov

akosyakov
akosyakov approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov
Copy link
Member

@geropl could you have a look?

@geropl geropl self-assigned this Apr 27, 2022
@geropl
Copy link
Member

geropl commented Apr 27, 2022

@geropl could you have a look?

@akosyakov Will do after all-hands. 👍

@iQQBot
Copy link
Contributor

iQQBot commented Apr 27, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-hw-fix-ide-choose.1
(with .werft/ from main)

geropl
geropl approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tests are green ✔️

@roboquat roboquat merged commit 58ceb91 into main Apr 27, 2022
@roboquat roboquat deleted the hw/fix-ide-choose branch April 27, 2022 15:15
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@akosyakov akosyakov akosyakov approved these changes

@andreafalzetti andreafalzetti Awaiting requested review from andreafalzetti

Assignees

@geropl geropl

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mustard-mh @akosyakov @geropl @iQQBot @roboquat