Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E tests TestBaseImageBuild and TestParallelBaseImageBuild #9540

Merged
merged 5 commits into from
Apr 26, 2022
Merged

Fix E2E tests TestBaseImageBuild and TestParallelBaseImageBuild #9540

merged 5 commits into from
Apr 26, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Apr 26, 2022

Description

Fix E2E tests TestBaseImageBuild and TestParallelBaseImageBuild.

Related Issue(s)

Partially address #8800

How to test

go test -v ./... \
    -kubeconfig=/home/gitpod/.kube/config
    -namespace=<namespace> \
    -run TestBaseImageBuild

go test -v ./... \
    -kubeconfig=/home/gitpod/.kube/config
    -namespace=<namespace> \
    -run TestParallelBaseImageBuild

Release Notes

NONE

Documentation

No

@jenting jenting requested a review from a team April 26, 2022 05:47
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 26, 2022
@jenting
Copy link
Contributor Author

jenting commented Apr 26, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run github with-vm=true

👍 started the job as gitpod-build-jenting-fix-broken-integration-8800.35
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Apr 26, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-jenting-fix-broken-integration-8800.36
(with .werft/ from main)

@princerachit
Copy link
Contributor

princerachit commented Apr 26, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-vm=true

👍 started the job as gitpod-build-jenting-fix-broken-integration-8800.37
(with .werft/ from main)

jenting added 5 commits April 26, 2022 13:17
@jenting
Remove duplicate scancel()
44f37a8 
We already have a defer scancel().

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting
Fix typo
3ee3087 
Signed-off-by: JenTing Hsiao <[email protected]>
@jenting
Fix potential bug once we change the value of parallel variable
fc3595c 
Signed-off-by: JenTing Hsiao <[email protected]>
@jenting
Better error message
8863f97 
To differentiate the error message.

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting
[werft] fix image pull secret not render
ea8ca9b 
Specify the kubeconfig file to use.

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting force-pushed the jenting/fix-broken-integration-8800 branch from fbb8233 to ea8ca9b Compare April 26, 2022 13:20
@roboquat roboquat merged commit 66ba0b1 into main Apr 26, 2022
@roboquat roboquat deleted the jenting/fix-broken-integration-8800 branch April 26, 2022 17:12
@jenting jenting linked an issue Apr 26, 2022 that may be closed by this pull request
Fix broken integration tests TestBaseImageBuild and TestParallelBaseImageBuild #8800
Closed
@jenting jenting removed a link to an issue Apr 27, 2022
Fix broken integration tests TestBaseImageBuild and TestParallelBaseImageBuild #8800
Closed
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jenting @princerachit @sagor999 @roboquat