-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ide] Disable the exit dialog on JetBrains IDEs #9528
Conversation
451c6e2
to
a5d3418
Compare
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-vn-jetbrains-supress-closing-8037.3 |
I think Werft is having the common error "no space left on device" :( |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-vn-jetbrains-supress-closing-8037.4 |
/werft run 👍 started the job as gitpod-build-vn-jetbrains-supress-closing-8037.5 |
/werft run |
a5d3418
to
50199bd
Compare
49029fb
to
e247aee
Compare
/unhold Alright, now it works for any JetBrains IDE! |
e247aee
to
fb18378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thank you @felladrin !
Description
This disables the following exit dialog on JetBrains IDEs, as, in Gitpod, the IDE state is totally controlled by the Supervisor. So when user clicks "X" to close the Thin Client window, this dialog will not be displayed anymore.
Related Issue(s)
Resolves #8037
How to test
cat $(find /ide-desktop/backend/bin/ -name "*64.vmoptions")
and confirm if the file contains the line-Dgtw.disable.exit.dialog=true
(this line is appended to the file during the image build, so it should be around the end of the file).Release Notes
Documentation