Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ide] Disable the exit dialog on JetBrains IDEs #9528

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Apr 25, 2022

Description

This disables the following exit dialog on JetBrains IDEs, as, in Gitpod, the IDE state is totally controlled by the Supervisor. So when user clicks "X" to close the Thin Client window, this dialog will not be displayed anymore.

image

Related Issue(s)

Resolves #8037

How to test

  1. Open a new workspace on any JetBrains IDE. Here are some suggestions (you just need to check one of them):
  2. After the JetBrains Client is open, on the Terminal, run cat $(find /ide-desktop/backend/bin/ -name "*64.vmoptions") and confirm if the file contains the line -Dgtw.disable.exit.dialog=true (this line is appended to the file during the image build, so it should be around the end of the file).
    image
  3. Close the IDE by clicking "X" or by the menu option "Quit JetBrains Client").
  4. Confirm that the IDE gets closed without displaying the exit dialog.

Release Notes

JetBrains IDEs won't show an exit dialog anymore, as the text on it was not necessary when running on Gitpod.

Documentation

  • /werft with-vm=true

@felladrin felladrin requested a review from a team April 25, 2022 14:05
@felladrin felladrin force-pushed the vn/jetbrains-supress-closing-8037 branch from 451c6e2 to a5d3418 Compare April 25, 2022 15:11
@felladrin
Copy link
Contributor Author

felladrin commented Apr 25, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-vn-jetbrains-supress-closing-8037.3
(with .werft/ from main)

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Apr 25, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-vn-jetbrains-supress-closing-8037.3 (with .werft/ from main)

I think Werft is having the common error "no space left on device" :(

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Apr 25, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-vn-jetbrains-supress-closing-8037.4
(with .werft/ from main)

@iQQBot
Copy link
Contributor

iQQBot commented Apr 25, 2022

/werft run

👍 started the job as gitpod-build-vn-jetbrains-supress-closing-8037.5
(with .werft/ from main)

@felladrin felladrin self-assigned this Apr 25, 2022
@iQQBot
Copy link
Contributor

iQQBot commented Apr 25, 2022

/werft run

@iQQBot iQQBot force-pushed the vn/jetbrains-supress-closing-8037 branch from a5d3418 to 50199bd Compare April 25, 2022 17:30
@mustard-mh
Copy link
Contributor

Not works for me

image

@felladrin
Copy link
Contributor Author

/hold

I've just noticed we'll need to add a .vmoptions for each JetBrains IDE (e.g. idea64.vmoptions, goland64.vmoptions, ...).

image

@felladrin felladrin force-pushed the vn/jetbrains-supress-closing-8037 branch from 49029fb to e247aee Compare April 25, 2022 21:24
@felladrin
Copy link
Contributor Author

/unhold

Alright, now it works for any JetBrains IDE!

@iQQBot iQQBot force-pushed the vn/jetbrains-supress-closing-8037 branch from e247aee to fb18378 Compare April 26, 2022 05:28
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thank you @felladrin !

@roboquat roboquat merged commit 7738ae7 into main Apr 26, 2022
@roboquat roboquat deleted the vn/jetbrains-supress-closing-8037 branch April 26, 2022 05:40
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/XS team: IDE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[jetbrains] suppress closing IDE backend dialog
6 participants