Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev image #9465

Merged
merged 8 commits into from
Apr 25, 2022
Merged

Update dev image #9465

merged 8 commits into from
Apr 25, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 21, 2022 •
edited
Loading

Description

Updates:

  • go to 1.18.1
  • protoc to 3.20
  • k8s.io to v0.23.5
  • google.golang.org/grpc v1.45.0
  • google.golang.org/protobuf v1.28.0
  • github.com/containerd/containerd v1.6.2
  • github.com/gorilla/websocket v1.5.0
  • sigs.k8s.io/controller-runtime v0.11.2

Release Notes

Update dev image, switch to go 1.18.1 and update dependencies

@aledbf
Copy link
Member Author

aledbf commented Apr 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👎 cannot start job - please talk to whoever's in charge of your Werft installation

@aledbf
Copy link
Member Author

aledbf commented Apr 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-go.8

@aledbf aledbf force-pushed the aledbf/go branch 2 times, most recently from 4832cb9 to 788fc8a Compare April 21, 2022 20:24
@aledbf aledbf marked this pull request as ready for review April 21, 2022 21:31
@aledbf aledbf requested review from a team April 21, 2022 21:31
@aledbf aledbf requested review from a team April 21, 2022 21:31
@github-actions github-actions bot added team: IDE team: devx team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Apr 21, 2022
sagor999
sagor999 previously approved these changes Apr 22, 2022
View reviewed changes
@aledbf aledbf dismissed stale reviews from mads-hartmann, mrsimonemms, geropl, and sagor999 via 1ee636b April 22, 2022 10:23
@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

iQQBot
iQQBot approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aledbf aledbf requested review from csweichel and geropl April 22, 2022 13:46
@geropl geropl mentioned this pull request Apr 25, 2022
Merged
@roboquat roboquat merged commit 1b88c80 into main Apr 25, 2022
@roboquat roboquat deleted the aledbf/go branch April 25, 2022 10:22
@easyCZ
Copy link
Member

easyCZ commented Apr 25, 2022

Looks like our gometalinter no longer works with 1.18

level=warning msg="[linters context] gosimple is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] unused is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."

@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@Furisto Furisto Furisto approved these changes

@sagor999 sagor999 sagor999 approved these changes

@iQQBot iQQBot iQQBot approved these changes

@csweichel csweichel csweichel approved these changes

@akosyakov akosyakov akosyakov approved these changes

@mrsimonemms mrsimonemms mrsimonemms approved these changes

@mads-hartmann mads-hartmann mads-hartmann approved these changes

Assignees

@geropl geropl

Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: devx team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.