Add new 'building' phase to workspaces

[andrew-farries]

Description

Add a new building phase to the list of phases that a workspace passes through on its way to running. A workspace is in building iff its workspace docker image is being built.

Related Issue(s)

Part of #9410

How to test

Refactoring that should have no effect on behaviour:

• Visit the preview environment for this PR
• Add a new project and start a workspace from it.
• The workspace starts up as normal.

Release Notes

NONE

Documentation

None

• /werft with-vm=true

[andrew-farries]

Imagebuilds are currently failing in the preview environment for this branch, but I don't think it's related to these changes:

[andrew-farries]

All comments addressed @geropl. Still two outstanding issues that stop me having full confidence in this:

• Imagebuilds are failing in the preview environment (see this comment)
• tsserver reports errors on every usage of the new building phase, eg:
  
  This doesn't stop the build, but is consistent between workspace restarts 🤔

[svenefftinge]

The tsserver error goes away when you rebuild the gitpod-protocol and restart the TypeScript Language Server (VS Code command).

[geropl]

Imagebuilds are currently failing in the preview environment for this branch, but I don't think it's related to these changes:

@andrew-farries This is a recent bug we saw with preview-environments. I recommend trying to 1) rebase on main and 2) use with-vm=true as werft parameter.

tsserver reports errors on every usage of the new building phase, eg:

If you do yarn watch in components/server, for instance, it should rebuild all direct and transitive dependencies. Sometimes you have to restart tsserver manually, though, because it does not catch up all changes from fs.

[meysholdt]

hey, can you please rebase your branch before you continue working with your preview env? The old base contains a ws-daemon that logs expensively.

To save costs, I'll manually remove the old preview env of this branch. Apologies for the inconvenience.

[andrew-farries]

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-af-add-new-workspace-phase.14
(with .werft/ from main)

[andrew-farries]

@meysholdt the Werft build for the branch fails after the rebase (with a clean slate deployment). Looks like its timing out trying to delete the staging-af-add-new0028eb5a0f namespace.

[geropl]

Looking into the preview issues here 👀

[geropl]

/werft run

👍 started the job as gitpod-build-af-add-new-workspace-phase.18
(with .werft/ from main)

[geropl]

@andrew-farries If you could fix this comment we're good to go! Tests looked good otherwise, code as well! 👍

[geropl]

Tested and works, code LGTM! 🙏

[mustard-mh]

Code looks good.

@akosyakov But we will never access to other phases...

• Gateway only opened if workspace phase is runing
• Gateway will exit once we click Stop Workspace in browser

Why we need this? Is it a preparation for the future(like create workspace without browser)?

[akosyakov]

@mustard-mh you can connect on any phase from GW ui already now. In the future we would like to avoid going to browser at all.

[geropl]

@akosyakov @mustard-mh Please note: this is just adding the type, and adding forward-compatible handlers (e.g., treating it as equal to "preparing"). We'll wait with the follow up PR to actually enable it once we switched all clients. W