Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow workspace timeouts to be extended when a user has workspaces in multiple regions #9427

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Fix #9174 by correctly taking account of a workspace's region when extending workspace timeouts.

Related Issue(s)

Fixes #9174

How to test

TBD

Release Notes

Allow workspace timeouts to be extended when a user has workspaces in different regions.

Documentation

None

/hold

Don't assume that the region of each workspace that needs its timeout
extended is in the same region as the workspace for which the extension was
requested.
@andrew-farries andrew-farries requested a review from a team April 20, 2022 14:01
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 20, 2022
@geropl geropl self-assigned this Apr 20, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested single region and it still works, and code LGTM. Thx! 💪

@andrew-farries
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit beb02b6 into main Apr 20, 2022
@roboquat roboquat deleted the andrew-farries/extending-workspace-9174 branch April 20, 2022 15:30
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending workspace timeouts fails when workspaces are running in multiple regions
3 participants