Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking users by matching email domains suffixes #9409

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Blocking users by matching email domains suffixes #9409

merged 2 commits into from
Apr 20, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Apr 19, 2022 •
edited
Loading

Description

Related Issue(s)

Fixes #9408 .

How to test

  • run tests and see they are green
  • try to signup here with an primary email that ends on itpod.io
  • try to open a workspace and see that you are blocked ❌

Release Notes

block abusers based on email domain suffixes

Documentation

@geropl geropl requested a review from a team April 19, 2022 19:35
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 19, 2022
jankeromnes
jankeromnes approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool, looks good to me and works as advertised. 👍 Many thanks!

Also big kudos on adding tests. 💯

Please simply fix the two micro-nits, then I'll quickly re-approve. 😁🚀

/hold

components/gitpod-db/src/email-domain-filter-db.ts Show resolved Hide resolved
components/gitpod-db/src/email-domain-filter-db.ts Outdated Show resolved Hide resolved
components/gitpod-db/src/typeorm/email-domain-filter-db-impl.ts Show resolved Hide resolved
components/server/ee/src/auth/email-domain-service.ts Show resolved Hide resolved
jankeromnes
jankeromnes previously approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(EDIT: double post, sorry)

@geropl geropl force-pushed the gpl/9408-edomains branch from 79d8d1d to 39c4ec5 Compare April 20, 2022 06:42
jankeromnes
jankeromnes approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me after the force-push. 👍

@geropl
Copy link
Member Author

geropl commented Apr 20, 2022

/unhold

@roboquat roboquat merged commit 424152c into main Apr 20, 2022
@roboquat roboquat deleted the gpl/9408-edomains branch April 20, 2022 06:52
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev left review comments

@jankeromnes jankeromnes jankeromnes approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pattern match email domains for blocking abusers
4 participants
@geropl @jankeromnes @AlexTugarev @roboquat