ws-daemon: align to decide if cgroup v2. #9390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/ws-daemon/pkg/iws/iws.go
Outdated
| if cgroups.Mode() == cgroups.Unified { | ||
| unified, err := cgroups.IsUnifiedCgroupSetup() | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.FailedPrecondition, "could not determine cgroup setup") |
There was a problem hiding this comment.
should we include the error err in the message?
There was a problem hiding this comment.
This error might be exposed to the user to whom it would be confusing.
We should log this instead.
|
@utam0k can you attach a screenshot where it shows that the issue is resolved, or maybe include a loom video so all reviewers don't have to explicitly test? |
sagor999
reviewed
Apr 19, 2022
|
@utam0k While discussing the cgroup issues Pavel had with his PVC work, we discovered that the method to evacuate the cgroup does not get called when using fuse. I have fixed that and added it to this PR. |
sagor999
approved these changes
Apr 19, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason, the existing decision process was not working properly to determine using cgroup v2.
Related Issue(s)
Fixes #9389
How to test
Create the cgroup v2 with fusefs environment and run a workspace.
https://github.com/gitpod-io/workspace-preview/tree/to/fusefs
Release Notes
Documentation
No