Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Support image-builder on ws-manager gRPC connection #9335

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

csweichel
Copy link
Contributor

Description

This PR exposes image-builder on the ws-manager gRPC connection.
It's part of an effort to move the image builder to the workspace cluster.

Related Issue(s)

Part of #9248

How to test

Try to interact with the image builder through ws-manager, e.g.

gpctl clusters get-tls-config
kubectl port-forward ws-manager-85c5cd445c-chh2d 8080:8080 &
gpctl imagebuilds --host localhost:8080 --tls-path wsman-tls list

Release Notes

Make image-builder available through ws-manager

@csweichel csweichel marked this pull request as ready for review April 14, 2022 16:38
@csweichel csweichel requested a review from a team April 14, 2022 16:38
@csweichel csweichel requested review from a team April 14, 2022 16:38
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Apr 14, 2022
@csweichel
Copy link
Contributor Author

csweichel commented Apr 14, 2022

/werft run no-preview

👍 started the job as gitpod-build-cw-imgbldr-mv-i.2

sagor999
sagor999 previously approved these changes Apr 14, 2022
geropl
geropl previously approved these changes Apr 14, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works

aledbf
aledbf previously approved these changes Apr 18, 2022
@mrsimonemms
Copy link
Contributor

/hold I'm currently experiencing a problem with getting images built on a self-hosted instance. Just doing some more testing to see whether this is caused by this PR or not

@corneliusludmann corneliusludmann self-requested a review April 19, 2022 10:22
@corneliusludmann corneliusludmann dismissed their stale review April 19, 2022 10:24

see Simons comment

@corneliusludmann corneliusludmann requested review from mrsimonemms and removed request for corneliusludmann April 19, 2022 10:24
@mrsimonemms
Copy link
Contributor

mrsimonemms commented Apr 19, 2022

It does look like this PR breaks image building, at least in my very specific instance. I'm using an Azure AKS cluster with all in-cluster dependencies specified. When running with the latest release, everything works as normal.

However, when running with the same config file (save for removing the new config params added), I get this in the imagebuild pod

{"level":"info","message":"connected to parent socket","ring":2,"serviceContext":{"service":"workspacekit","version":"commit-0afb0b3244b40bc220db1b39138e3af47a1cfab1"},"severity":"INFO","time":"2022-04-19T10:12:01Z"}
{"level":"info","message":"signaling to child process","ring":1,"serviceContext":{"service":"workspacekit","version":"commit-0afb0b3244b40bc220db1b39138e3af47a1cfab1"},"severity":"INFO","time":"2022-04-19T10:12:01Z"}
{"level":"info","message":"awaiting seccomp fd","ring":1,"serviceContext":{"service":"workspacekit","version":"commit-0afb0b3244b40bc220db1b39138e3af47a1cfab1"},"severity":"INFO","time":"2022-04-19T10:12:01Z"}
{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","cmd":"/.supervisor/supervisor","error":"no such file or directory","level":"error","message":"cannot exec","ring":2,"serviceContext":{"service":"workspacekit","version":"commit-0afb0b3244b40bc220db1b39138e3af47a1cfab1"},"severity":"ERROR","time":"2022-04-19T10:12:01Z"}
{"level":"info","message":"done","ring":2,"serviceContext":{"service":"workspacekit","version":"commit-0afb0b3244b40bc220db1b39138e3af47a1cfab1"},"severity":"INFO","time":"2022-04-19T10:12:01Z"}
{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","error":"exit status 1","level":"error","message":"unexpected exit","ring":1,"serviceContext":{"service":"workspacekit","version":"commit-0afb0b3244b40bc220db1b39138e3af47a1cfab1"},"severity":"ERROR","time":"2022-04-19T10:12:01Z"}
{"level":"info","message":"done","ring":1,"serviceContext":{"service":"workspacekit","version":"commit-0afb0b3244b40bc220db1b39138e3af47a1cfab1"},"severity":"INFO","time":"2022-04-19T10:12:01Z"}
{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","error":"exit status 1","level":"error","message":"unexpected exit","ring":0,"serviceContext":{"service":"workspacekit","version":"commit-0afb0b3244b40bc220db1b39138e3af47a1cfab1"},"severity":"ERROR","time":"2022-04-19T10:12:01Z"}
2022/04/19 10:12:02 cannot open /proc/27/root: open /proc/27/root: no such file or directory

If anyone wants to sync on this, let me know and I'll show you with my instance

@csweichel
Copy link
Contributor Author

I'd think it's this issue here; #9344

@csweichel
Copy link
Contributor Author

will rebase

@csweichel csweichel dismissed stale reviews from geropl and sagor999 via 4f5fb05 April 19, 2022 10:36
@csweichel
Copy link
Contributor Author

csweichel commented Apr 19, 2022

/werft run no-preview

👍 started the job as gitpod-build-cw-imgbldr-mv-i.4

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Apr 19, 2022

/werft run

👍 started the job as gitpod-build-cw-imgbldr-mv-i.6

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rebase worked 👍🏻

@mrsimonemms
Copy link
Contributor

/unhold

@aledbf aledbf self-requested a review April 19, 2022 16:17
@roboquat roboquat merged commit dac6262 into main Apr 19, 2022
@roboquat roboquat deleted the cw/imgbldr-mv-i branch April 19, 2022 16:17
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production labels Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note size/L team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants