-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager] Support image-builder on ws-manager gRPC connection #9335
Conversation
/werft run no-preview 👍 started the job as gitpod-build-cw-imgbldr-mv-i.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested and works
/hold I'm currently experiencing a problem with getting images built on a self-hosted instance. Just doing some more testing to see whether this is caused by this PR or not |
It does look like this PR breaks image building, at least in my very specific instance. I'm using an Azure AKS cluster with all in-cluster dependencies specified. When running with the latest release, everything works as normal. However, when running with the same config file (save for removing the new config params added), I get this in the
If anyone wants to sync on this, let me know and I'll show you with my instance |
I'd think it's this issue here; #9344 |
will rebase |
1ec9480
to
4f5fb05
Compare
/werft run no-preview 👍 started the job as gitpod-build-cw-imgbldr-mv-i.4 |
4f5fb05
to
b6906d7
Compare
/werft run 👍 started the job as gitpod-build-cw-imgbldr-mv-i.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rebase worked 👍🏻
/unhold |
Description
This PR exposes image-builder on the ws-manager gRPC connection.
It's part of an effort to move the image builder to the workspace cluster.
Related Issue(s)
Part of #9248
How to test
Try to interact with the image builder through ws-manager, e.g.
gpctl clusters get-tls-config kubectl port-forward ws-manager-85c5cd445c-chh2d 8080:8080 & gpctl imagebuilds --host localhost:8080 --tls-path wsman-tls list
Release Notes